Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix in memcache.php #71

Merged
merged 1 commit into from Mar 30, 2013

Conversation

Projects
None yet
3 participants
Contributor

pedroresende commented Mar 27, 2013

No description provided.

Contributor

lolautruche commented Mar 27, 2013

Hi
Can you please add a description ? 😃

Contributor

pedroresende commented Mar 27, 2013

The problem was the the $server array has been defined with the keys 'server', 'port' and 'weight' and it was trying to get them by integer position.
This would generate a Symfony Stack Trace with the following error

"Notice: Undefined offset: 0 in ../Stash/Driver/Sub/Memcache.php line 33"

@lolautruche lolautruche referenced this pull request in tedious/TedivmStashBundle Mar 27, 2013

Merged

Fixed Memcache driver configuration #16

@tedivm tedivm added a commit that referenced this pull request Mar 30, 2013

@tedivm tedivm Merge pull request #71 from pedroresende/array_error
Fix in memcache.php
df441ca

@tedivm tedivm merged commit df441ca into tedious:master Mar 30, 2013

1 check failed

default The Travis build could not complete due to an error
Details

@tedivm tedivm added a commit that referenced this pull request Mar 30, 2013

@tedivm tedivm Revert "Merge pull request #71 from pedroresende/array_error"
This reverts commit df441ca, reversing
changes made to 1606a2b.
7cbe1b2
Owner

tedivm commented Mar 30, 2013

Sorry, had to revert this because it didn't work. Can you merge this master back in to yours, fix things so the tests run, and then issue a new PR? Thanks.

Contributor

lolautruche commented Mar 31, 2013

@tedivm This PR is pointless now that tedivm/TedivmStashBundle#16 has been merged.
The problem was in the bundle configuration, not in the Memcache driver 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment