Fixes #891 - Bulk Insert for NVARCHAR(MAX) Fields.#901
Fixes #891 - Bulk Insert for NVARCHAR(MAX) Fields.#901willmorgan merged 11 commits intotediousjs:masterfrom
Conversation
What this does: Fixes tediousjs#891 Adds the ability to set length for an NVARCHAR(MAX) column, which was breaking while bulk insertion.
dhensby
left a comment
dhensby
left a comment
There was a problem hiding this comment.
Thanks for this - ping @willmorgan for any thoughts
willmorgan
left a comment
willmorgan
left a comment
There was a problem hiding this comment.
Looks fine, needs tests though.
Updated options to check the property length Co-Authored-By: Will Morgan <willmorgan@users.noreply.github.com>
|
thanks @willmorgan , i will add the tests soon |
There was a problem hiding this comment.
@willmorgan @dhensby Added tests and refactored code to align with standard js styles
willmorgan
left a comment
willmorgan
left a comment
There was a problem hiding this comment.
Getting there @JP1016, just a few questions to answer and maybe a few more test scenarios then I think we're good to go. Thanks!
…ements for the tables
JP1016
left a comment
JP1016
left a comment
There was a problem hiding this comment.
@willmorgan @darryl-davidson Updated test cases with length: infinity, max, undefined and random string value
JP1016
left a comment
JP1016
left a comment
There was a problem hiding this comment.
Made changes accordingly.
JP1016
left a comment
JP1016
left a comment
There was a problem hiding this comment.
Added test cases for the scenarios
3 participants
What this does:
Fixes #891
Adds the ability to set length for an NVARCHAR(MAX) column, which was breaking while bulk insertion.