Pass the appName from the connection option object to the login payload constructor #91

Closed
mburbea opened this Issue Mar 26, 2013 · 1 comment

Projects

None yet

2 participants

@mburbea

https://github.com/pekim/tedious/blob/master/src/connection.coffee#L388
The call to the payload constructor is never assigned an appName attribute.
This means that when a trace is run all traffic from an application using tedious comes in with an application name of Tedious. It should be fairly simple fix.
Thanks and great work!

@pekim pekim closed this in fbdb764 Mar 27, 2013
@pekim

I haven't added an integration test for this, but I've tested it manually with examples/simple-client.js.
sp_who2 shows that if appName is supplied in config options it is now used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment