Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add parameter types (GUID, bigint, float) #45

Merged
merged 7 commits into from Sep 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

zachaller commented Aug 10, 2012

I added a few parameter types (GUID, bigint, float) as well as did some type parsing.

p.s. - not 100% sure about correctness of all this so please review was not sure if BigInt parsing if high order bits should be signed or not also.

zachaller added some commits Aug 9, 2012

@zachaller zachaller Add BigInt parameterize support
Signed-off-by: Zach Aller <zachaller@hotmail.com>
7ebf2e0
@zachaller zachaller better way to split up bigint's
Signed-off-by: Zach Aller <zachaller@hotmail.com>
dd34afe
@zachaller zachaller clean up b74265a
@zachaller zachaller add guid support for parameterization
Signed-off-by: Zach Aller <zachaller@hotmail.com>
cecf81f
@zachaller zachaller some type casting
Signed-off-by: Zach Aller <zachaller@hotmail.com>
101bb0a
Contributor

zachaller commented Aug 10, 2012

also with BigInt it still suffers from JS 53bit Int issues unless i was to include some BigInt lib but we just needed this asap because we are shortly going to release some software that uses this.

Contributor

zachaller commented Sep 4, 2012

also a bug with BigInt I am looking into is negative numbers don't work

zachaller added some commits Sep 5, 2012

@zachaller zachaller fix bigint negative numbers and test for them also
Signed-off-by: Zach Aller <zachaller@hotmail.com>
da3f853
@zachaller zachaller added some more test for big int as well as a proper fix
Signed-off-by: Zach Aller <zachaller@hotmail.com>
ef1c8b6

@pekim pekim added a commit that referenced this pull request Sep 8, 2012

@pekim pekim Merge pull request #45 from zachaller/master
Add parameter types (GUID, bigint, float)
2a498fb

@pekim pekim merged commit 2a498fb into tediousjs:master Sep 8, 2012

Collaborator

pekim commented Sep 8, 2012

Thanks for this. I am sorry that it took me so long to get around to reviewing it and merging it.

@momow momow pushed a commit to momow/tedious that referenced this pull request Oct 15, 2014

@bretcope bretcope Added correct Counters table script. fixes #45 548afcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment