Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

pulled/merged latest pekim/tedious master, added test for string guid #55

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

cortfritz commented Oct 29, 2012

No description provided.

Cort Fritz and others added some commits Oct 1, 2012

Cort Fritz Update src/guid-parser.coffee
helper to reverse the guid-to-array parsing for use on the way back out
049b39f
Cort Fritz moved guid parsing to buffer reading d687e25
Cort Fritz Merge branch 'master' of https://github.com/pekim/tedious
..to ensure I have latest.
4e815b8
Cort Fritz converted test to check for string guid on way out d90ccd7
Collaborator

pekim commented Oct 30, 2012

Microsoft documentation shows uniqueidentifiers with uppercase hex digits. I think that it would be better if the guid were exposed similarly formatted. Is that reasonable or not? I'm undecided.

Three integration tests fail, because they have not yet been updated.
To run all tests, including the integration tests, the scripts/tests-all script can be used.

The integration tests expect a file like this at $HOME/.tedious/test-connection.json .

{
  "config": {
    "server": "192.168.1.212",
    "userName": "test",
    "password": "test",
    "options": {
      "port": 1433,
      "connectTimeout": 1000,
      "database": "test"
    }
  }
}
Contributor

cortfritz commented Oct 30, 2012

Gotcha. All upper makes sense, if harder to read. :-). I will attack the integration tests.

(Sent from mobile so may contain thumb errors)

On Oct 30, 2012, at 9:48 AM, "Mike D Pilsbury" <notifications@github.commailto:notifications@github.com> wrote:

Microsoft documentation shows uniqueidentifiers with uppercase hex digits. I think that it would be better if the guid were exposed similarly formatted. Is that reasonable or not? I'm undecided.

Three integration tests fail, because they have not yet been updated.
To run all tests, including the integration tests, the scripts/tests-all script can be used.

The integration tests expect a file like this at $HOME/.tedious/test-connection.json .

{
"config": {
"server": "192.168.1.212",
"userName": "test",
"password": "test",
"options": {
"port": 1433,
"connectTimeout": 1000,
"database": "test"
}
}
}


Reply to this email directly or view it on GitHubhttps://github.com/pekim/tedious/pull/55#issuecomment-9913271.


This e-mail and any files transmitted with it are intended solely for the use of the individual or entity to whom they are addressed. If the reader of this e-mail is not the intended recipient or the employee or agent responsible for delivering the message to the intended recipient, you are hereby notified that any use dissemination, forwarding, printing or copying of this e-mail is strictly prohibited. If you have received this e-mail in error, please e-mail us at caasecurity@caa.com or call 424-288-2000.

@cortfritz cortfritz closed this Oct 30, 2012

Contributor

cortfritz commented Oct 30, 2012

submitting new pull request with full integration tests working

Contributor

cortfritz commented Oct 30, 2012

done. new pull submitted.

On Oct 30, 2012, at 9:54 AM, "Fritz, Cort" <CFritz@caa.commailto:CFritz@caa.com> wrote:

Gotcha. All upper makes sense, if harder to read. :-). I will attack the integration tests.

(Sent from mobile so may contain thumb errors)

On Oct 30, 2012, at 9:48 AM, "Mike D Pilsbury" <notifications@github.commailto:notifications@github.com> wrote:

Microsoft documentation shows uniqueidentifiers with uppercase hex digits. I think that it would be better if the guid were exposed similarly formatted. Is that reasonable or not? I'm undecided.

Three integration tests fail, because they have not yet been updated.
To run all tests, including the integration tests, the scripts/tests-all script can be used.

The integration tests expect a file like this at $HOME/.tedious/test-connection.json .

{
"config": {
"server": "192.168.1.212",
"userName": "test",
"password": "test",
"options": {
"port": 1433,
"connectTimeout": 1000,
"database": "test"
}
}
}


Reply to this email directly or view it on GitHubhttps://github.com/pekim/tedious/pull/55#issuecomment-9913271.


This e-mail and any files transmitted with it are intended solely for the use of the individual or entity to whom they are addressed. If the reader of this e-mail is not the intended recipient or the employee or agent responsible for delivering the message to the intended recipient, you are hereby notified that any use dissemination, forwarding, printing or copying of this e-mail is strictly prohibited. If you have received this e-mail in error, please e-mail us at caasecurity@caa.com or call 424-288-2000.

@momow momow pushed a commit to momow/tedious that referenced this pull request Oct 15, 2014

@bretcope bretcope Merge pull request #55 from StackExchange/wip-serve-a-stinking-ad
Implement the /a route for v0.2.0. Fixes #41
9da9c69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment