Duplicate column names support #70

Merged
merged 1 commit into from Feb 3, 2013

Conversation

Projects
None yet
2 participants
@nadeemc

nadeemc commented Jan 30, 2013

This makes it easier to re-use stored procedures that have duplicate
column names for multi-mapping between Dapper and tedious. When the same
column is used multiple times, you can reference it with:
row['columnName'][index].value

Single occurence columns would still work with row['columnName'].value.
There might be a more intuitive way of references the duplicated column,
so I'm open to ideas there.

nadeem
Ability to have duplicate column names
This makes it easier to re-use stored procedures that have duplicate
column names for multi-mapping between Dapper and tedious. When the same
column is used multiple times, you can reference it with:
row['columnName'][index].value

Single occurence columns would still work with row['columnName'].value.
There might be a more intuitive way of references the duplicated column,
so I'm open to ideas there.
@pekim

This comment has been minimized.

Show comment Hide comment
@pekim

pekim Jan 31, 2013

Collaborator

Thanks for this.

From a quick look, I think that it should be fine. It doesn't impact on the way that single-occurrence column names are exposed.

Before I merge this, I want to add an integration test or two for it. If I have time I'll do it this weekend, if not I'm pretty sure that I'll be able to do it the following weekend.

Collaborator

pekim commented Jan 31, 2013

Thanks for this.

From a quick look, I think that it should be fine. It doesn't impact on the way that single-occurrence column names are exposed.

Before I merge this, I want to add an integration test or two for it. If I have time I'll do it this weekend, if not I'm pretty sure that I'll be able to do it the following weekend.

@pekim pekim merged commit 60c24d1 into tediousjs:master Feb 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment