Add placeholder event handlers to suppress crash in final #80

Merged
merged 2 commits into from Mar 7, 2013

Conversation

Projects
None yet
2 participants
@drudge
Contributor

drudge commented Feb 21, 2013

No description provided.

@pekim

This comment has been minimized.

Show comment Hide comment
@pekim

pekim Feb 21, 2013

Collaborator

Can you provide some details of what circumstances cause a problem please? If I can, I'd like to add an integration test to reproduce the problem.

Collaborator

pekim commented Feb 21, 2013

Can you provide some details of what circumstances cause a problem please? If I can, I'd like to add an integration test to reproduce the problem.

@drudge

This comment has been minimized.

Show comment Hide comment
@drudge

drudge Feb 22, 2013

Contributor

@pekim I'll try, but I actually added this fix to my local version about 7 months ago and can't remember the exact case we were dealing with.

My second commit fixes a problem where passing a database would not actually work, it would always use the default database configured in SQL Server.

Contributor

drudge commented Feb 22, 2013

@pekim I'll try, but I actually added this fix to my local version about 7 months ago and can't remember the exact case we were dealing with.

My second commit fixes a problem where passing a database would not actually work, it would always use the default database configured in SQL Server.

pekim added a commit that referenced this pull request Mar 7, 2013

Merge pull request #80 from drudge/master
Add placeholder event handlers to suppress crash in final

@pekim pekim merged commit 3e51305 into tediousjs:master Mar 7, 2013

@pekim

This comment has been minimized.

Show comment Hide comment
@pekim

pekim Mar 23, 2013

This is not correct. database is meant to be a property of options.
This is documented at http://pekim.github.com/tedious/api-connection.html#function_newConnection .

pekim commented on b2b4c7a Mar 23, 2013

This is not correct. database is meant to be a property of options.
This is documented at http://pekim.github.com/tedious/api-connection.html#function_newConnection .

momow pushed a commit to momow/tedious that referenced this pull request Oct 15, 2014

momow pushed a commit to momow/tedious that referenced this pull request Oct 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment