Code refactor to use railtie, scope naming, and include alias method chain instead of alias. #10

Merged
merged 2 commits into from Mar 5, 2012

Projects

None yet

2 participants

@tommeier

Some changes to allow it to work with Rails 3.2 + Paperclip 2.7 (in conjunction with delayed_paperclip).

Because of how it was aliased, it wasn't being triggered in post process steps correctly. Did a minor refactor and all is good right now.

Specs are passing (nice to see they were testing the functionality not the implementation :)

tommeier added some commits Mar 4, 2012
@tommeier tommeier Fix for Paperclip 2.7 - assign and instantiate instance with papercli…
…p-meta value, update code to be scoped by name and use a railtie
c31c74f
@tommeier tommeier Fix for image.size, it is already a method on Paperclip::Attachment, …
…need to overwrite with optional parameter
3be52ac
@y8
Collaborator
y8 commented Mar 5, 2012

It will be compatible with older rails version after using railtie?

Btw, can you remove .rvmrc file from this pull request?

@y8 y8 closed this Mar 5, 2012
@y8 y8 reopened this Mar 5, 2012
@y8
Collaborator
y8 commented Mar 5, 2012

Ah, I see, it will.

@y8 y8 merged commit 617b5d3 into teeparham:master Mar 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment