New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 0.7 server popup is too small for the text #1843

Closed
Dune-jr opened this Issue Dec 11, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@Dune-jr
Copy link
Member

Dune-jr commented Dec 11, 2018

image

@sepulzera

This comment has been minimized.

Copy link
Contributor

sepulzera commented Dec 12, 2018

Imo we could remove the hash info. It is way too technical for the common user.
Wrong version. Server is running '0.7' and client '0.7 DDNet'.

The mods developer should be responsible to set the version string properly, if compatibility breaks.

@Dune-jr

This comment has been minimized.

Copy link
Member

Dune-jr commented Dec 12, 2018

  1. It's a problem with other messages, not just hash
  2. Mods shouldn't put info in their hash, that's not what it's for. It's to check for protocol incompatibilities and prevent very strange behaviors.
@sepulzera

This comment has been minimized.

Copy link
Contributor

sepulzera commented Dec 12, 2018

  1. For instance?
  2. You can check for protocol compatibility without displaying "random" numbers to the end user ;-)
    They are of no value except for devs.
@Dune-jr

This comment has been minimized.

Copy link
Member

Dune-jr commented Dec 12, 2018

  1. For instance?

I suspect if the popup window doesn't act nice with this message, it won't act nice with others. I vaguely remember this problem, but I don't have an instance to show off.

  1. You can check for protocol compatibility without displaying "random" numbers to the end user ;-)
    They are of no value except for devs.

Ah, so you meant changing the error message, I thought you meant scrapping the feature.

I guess it could say something like Protocols mismatch, server version incompatible. But having the hashes be displayed is very helpful to troubleshoot problems when those screenshots appear in support, so I don't think I like removing the hashes too much.

@nheir

This comment has been minimized.

Copy link
Contributor

nheir commented Dec 12, 2018

Let the full message in console then.

There is space in the dialog box, so for any other message that does not fit, it should break into two lines.

@oy oy added bug ui labels Dec 12, 2018

@oy oy closed this in 1bfbff2 Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment