New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to open configs in absolute paths since 0.7, reportedly #1872

Closed
Dune-jr opened this Issue Dec 15, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@Dune-jr
Copy link
Member

Dune-jr commented Dec 15, 2018

[5c142019][console]: failed to open '/home/teeworlds/twservermanager07/teeworlds/s1.conf'

Someone reported this error when upgrading from 0.6 to 0.7. I made sure with him that the file was indeed at that path. The permissions are correct too:

-rwxrwxrwx 1 teeworlds teeworlds 50 Dec 14 22:19 /home/teeworlds/twservermanager07/teeworlds/s1.conf

Local paths and autoexec.cfg still work.

@oy oy added the bug label Dec 15, 2018

@oy oy added this to the 0.7.2 milestone Dec 15, 2018

@ChillerDragon

This comment has been minimized.

Copy link
Contributor

ChillerDragon commented Dec 15, 2018

How do you load that config? I remember that DDNet decided to only allowed relative paths from specific starting points to fix security vulnerabilitys coming with the exec command. Because ingame admins could read text files even if they are not teeworlds configs.

@Dune-jr

This comment has been minimized.

Copy link
Member

Dune-jr commented Dec 15, 2018

With teeworlds_srv.exe -f path/to/config

@oy

This comment has been minimized.

Copy link
Member

oy commented Dec 16, 2018

Yeah, you can't use absolute paths. Just relative paths starting from the ones you specify in storage.cfg. So we prevent that someone pulls some shenanigan.

@oy oy removed this from the 0.7.2 milestone Dec 16, 2018

@oy oy removed the bug label Dec 16, 2018

@Dune-jr

This comment has been minimized.

Copy link
Member

Dune-jr commented Dec 17, 2018

So that's a feature. Then either do nothing and close the issue, or print some sort of error message on how we don't allow absolute paths.

@oy oy closed this in e76148c Dec 22, 2018

@Dune-jr

This comment has been minimized.

Copy link
Member

Dune-jr commented Dec 22, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment