Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap buffer overflow (read) while loading map in CMap::Load, map.cpp:77 #2969

Open
mmmds opened this issue Oct 23, 2021 · 0 comments · May be fixed by #2931
Open

Heap buffer overflow (read) while loading map in CMap::Load, map.cpp:77 #2969

mmmds opened this issue Oct 23, 2021 · 0 comments · May be fixed by #2931

Comments

@mmmds
Copy link

mmmds commented Oct 23, 2021

The client crashes (only with ASAN) when an invalid map (2.map.zip) is loaded. Such a map can be delivered to the client by a malicious server.

Tested on Ubuntu 20.04 x86_64, Teeworlds version: f35da54b6f2c5f9fd4bbd4559f887ccf8f8cc526

Compilation with ASAN:

export CXXFLAGS="-ggdb -O0 -fsanitize=address -fno-omit-frame-pointer"
export CFLAGS="-ggdb -O0 -fsanitize=address -fno-omit-frame-pointer"
cmake ..
make

Run and connect to a server that delivers an invalid map:

./teeworlds "connect 127.0.0.1" "gfx_fullscreen 0" "gfx_screen_height 240" "gfx_screen_width 360"
[...]
=================================================================
==31354==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6130000141f0 at pc 0x55555599658c bp 0x7ffffffd8c80 sp 0x7ffffffd8c70
READ of size 4 at 0x6130000141f0 thread T0
    #0 0x55555599658b in CMap::Load(char const*, IStorage*) /home/osboxes/teeworlds/teeworlds-asan/src/engine/shared/map.cpp:77
    #1 0x5555555f0c6f in CClient::LoadMap(char const*, char const*, SHA256_DIGEST const*, unsigned int) /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:807
    #2 0x5555555f8408 in CClient::ProcessServerPacket(CNetChunk*) /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:1251
    #3 0x5555555f997e in CClient::PumpNetwork() /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:1596
    #4 0x5555555f9d46 in CClient::Update() /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:1766
    #5 0x5555555fc9a0 in CClient::Run() /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:2108
    #6 0x5555555d24e5 in main /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:2704
    #7 0x7ffff68e10b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
    #8 0x5555555dc48d in _start (/home/osboxes/teeworlds/teeworlds-asan/build/teeworlds+0x8848d)

0x6130000141f0 is located 0 bytes to the right of 368-byte region [0x613000014080,0x6130000141f0)
allocated by thread T0 here:
    #0 0x7ffff768ebc8 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dbc8)
    #1 0x555555973f35 in CDataFileReader::GetDataImpl(int, int) /home/osboxes/teeworlds/teeworlds-asan/src/engine/shared/datafile.cpp:303
    #2 0x555555973f35 in CDataFileReader::GetData(int) /home/osboxes/teeworlds/teeworlds-asan/src/engine/shared/datafile.cpp:341
    #3 0x555555996356 in CMap::Load(char const*, IStorage*) /home/osboxes/teeworlds/teeworlds-asan/src/engine/shared/map.cpp:72
    #4 0x5555555f0c6f in CClient::LoadMap(char const*, char const*, SHA256_DIGEST const*, unsigned int) /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:807
    #5 0x5555555f8408 in CClient::ProcessServerPacket(CNetChunk*) /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:1251
    #6 0x5555555f997e in CClient::PumpNetwork() /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:1596
    #7 0x5555555f9d46 in CClient::Update() /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:1766
    #8 0x5555555fc9a0 in CClient::Run() /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:2108
    #9 0x5555555d24e5 in main /home/osboxes/teeworlds/teeworlds-asan/src/engine/client/client.cpp:2704
    #10 0x7ffff68e10b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/osboxes/teeworlds/teeworlds-asan/src/engine/shared/map.cpp:77 in CMap::Load(char const*, IStorage*)
Shadow bytes around the buggy address:
  0x0c267fffa7e0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c267fffa7f0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c267fffa800: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
  0x0c267fffa810: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c267fffa820: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c267fffa830: 00 00 00 00 00 00 00 00 00 00 00 00 00 00[fa]fa
  0x0c267fffa840: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fffa850: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fffa860: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fffa870: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fffa880: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==31354==ABORTING

Doesn't crash without ASAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants