Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change_map command not always changing (close #1841) #1871

merged 3 commits into from Dec 16, 2018


Copy link

@sepulzera sepulzera commented Dec 15, 2018

After applying this PR, the change_map command will work even

  • when in warmup
  • when the map is not finished (sv_matches_per_map)

As this is my first PR for teeworlds, I hope to satisfy the code guidelines and quality standard :-)

sepulzera added 2 commits Dec 14, 2018
After applying this commit, the change_map command will work even
- when in warmup
- when the map is not finished (sv_matches_per_map)
Copy link

@fokkonaut fokkonaut commented Dec 15, 2018

just remove that command, we have sv_map.

Copy link

@Dune-jr Dune-jr commented Dec 15, 2018

Seems good.
I wouldn't mind change_map to no longer work with a parameter though.

if(m_MatchCount >= m_GameInfo.m_MatchNum-1)

This comment has been minimized.


oy Dec 15, 2018

this breaks the game in case sv_maprotation is empty.

This comment has been minimized.


sepulzera Dec 16, 2018
Author Contributor

Thanks for the nice catch, oy!
I removed the break, now it works as intended, with and without sv_maprotation being set.

@oy oy merged commit 5ec0efd into teeworlds:master Dec 16, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
@sepulzera sepulzera deleted the sepulzera:fix-1841 branch Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants