Fix change_map command not always changing (close #1841) #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After applying this commit, the change_map command will work even - when in warmup - when the map is not finished (sv_matches_per_map)
|
just remove that command, we have sv_map. |
|
Seems good. |
oy
reviewed
Dec 15, 2018
src/game/server/gamecontroller.cpp
Outdated
| if(m_MatchCount >= m_GameInfo.m_MatchNum-1) | ||
| { | ||
| CycleMap(); | ||
| break; |
There was a problem hiding this comment.
this breaks the game in case sv_maprotation is empty.
There was a problem hiding this comment.
Thanks for the nice catch, oy!
I removed the break, now it works as intended, with and without sv_maprotation being set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After applying this PR, the change_map command will work even
As this is my first PR for teeworlds, I hope to satisfy the code guidelines and quality standard :-)