Skip to content

Fix change_map command not always changing (close #1841) #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2018

Conversation

sepulzera
Copy link
Contributor

After applying this PR, the change_map command will work even

  • when in warmup
  • when the map is not finished (sv_matches_per_map)

As this is my first PR for teeworlds, I hope to satisfy the code guidelines and quality standard :-)

After applying this commit, the change_map command will work even
- when in warmup
- when the map is not finished (sv_matches_per_map)
@fokkonaut
Copy link
Contributor

just remove that command, we have sv_map.

@Dune-jr
Copy link
Member

Dune-jr commented Dec 15, 2018

Seems good.
I wouldn't mind change_map to no longer work with a parameter though.

if(m_MatchCount >= m_GameInfo.m_MatchNum-1)
{
CycleMap();
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks the game in case sv_maprotation is empty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice catch, oy!
I removed the break, now it works as intended, with and without sv_maprotation being set.

@oy oy merged commit 5ec0efd into teeworlds:master Dec 16, 2018
@sepulzera sepulzera deleted the fix-1841 branch December 16, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants