New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use colorful gametype and level icons in the browser instead of grayscale #1904

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
4 participants
@Dune-jr
Copy link
Member

Dune-jr commented Dec 18, 2018

See #1903 proposal

@Zatline

This comment has been minimized.

Copy link
Member

Zatline commented Dec 18, 2018

agree and disagree, I'd like to suggest a middle path that could lead to a more dynamic experience

mouse over -> icon gets colored instantly
mouse moves away -> colored icon fades into white
-> the selected row is colored and stays colored until release

@Dune-jr

This comment has been minimized.

Copy link
Member

Dune-jr commented Dec 18, 2018

I'm answering over at #1903. It's best to keep the discussion in one place.

@1stDecadeTW

This comment has been minimized.

Copy link

1stDecadeTW commented Dec 18, 2018

I prefer the original idea, to always keep gametypes and level icons colorful... The main reason of the icons is to distinguish between gametypes, and the mouse hover effect doesn't contribute to that purpose.

@oy oy merged commit 157c2d1 into teeworlds:master Dec 19, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Dune-jr Dune-jr deleted the Dune-jr:feature-colorful-browser branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment