Broadcast: parse new line character #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -315,6 +315,16 @@ void CBroadcast::OnMessage(int MsgType, void* pRawMsg) | |||
| } | |||
| } | |||
|
|
|||
| if(*c == CharUtf8 && *c == '\n') | |||
There was a problem hiding this comment.
*c == CharUtf8 is unnecessary, the '\n' is always a literal \n in UTF-8:
From UTF-8 on Wikipedia:
The first 128 characters of Unicode, which correspond one-to-one with ASCII, are encoded using a single octet with the same binary value as ASCII, so that valid ASCII text is valid UTF-8-encoded Unicode as well. Since ASCII bytes do not occur when encoding non-ASCII code points into UTF-8, UTF-8 is safe to use within most programming and document languages that interpret certain ASCII characters in a special way, such as "/" in filenames, "" in escape sequences, and "%" in printf.
There was a problem hiding this comment.
Alright thanks @heinrich5991.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had unintended behaviour, it was only parsed by the text function at the end and thus would cause the text to be mis-positioned. The new line character can only be sent via code modification so this was only an issue for mods.
"Sometext\nOOP new ^900LINE\\nAnother ^090one"