-
Notifications
You must be signed in to change notification settings - Fork 650
Demo list marker indicator #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Finally a reason to upgrade to 0.7! Is it possible to sort or order only the demos with markers out? For people like me with millions of demos who sometimes forget to sort out the good ones for weeks. |
|
@ChillerDragon I'm glad you like it, although there is something I need to clarify. Short answer: we can't yet. |
|
Thanks. Maybe there should be a naming convention when the client saves a demo to signal the existence of markers. It is somewhat counter-intuitive for anyone who doesn't read the patch notes to have to click on a demo to check for markers if that marker is displayed on the list. Should it only be shown on the demo details, to not mislead anyone? |
src/game/client/components/menus.cpp
Outdated
| pState->m_ListBoxDoneEvents = 1; | ||
|
|
||
| if(m_EnterPressed || (UI()->CheckActiveItem(pId) && Input()->MouseDoubleClick())) | ||
| if(m_EnterPressed || (UI()->LastActiveItem() == pId && Input()->MouseDoubleClick())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do that. Could lead to a GUI lock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fixed.
|
Imo this searching for demos with markers doesn't have to be asynchronously. It would be nice to press a button somewhere and actually get a freeze maybe even with a nice loading bar / status. Loading multiple of 300min+ demos can take a while and a status would be nice instead of not knowing what is happening in the background. And yes I can promise you it happens that people leave their client open 24/7 hours multiple days. And rarley switch server/maps probably less likley in vanilla but i think we agreed on supporting mods a bit c: |
When a demo info is loaded and has markers, the icon becomes green. Markers are also displayed in the info section. It doesn't look amazing but it's functional. We can perhaps do a better job designing this part of the UI later.
Edit: "not loaded" status is now a grey icon.
I also fixed a double click issue (a triple click was needed and even that sometimes didn't work).