New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo list marker indicator #1913

Merged
merged 4 commits into from Dec 22, 2018

Conversation

Projects
None yet
4 participants
@LordSk
Copy link
Member

LordSk commented Dec 21, 2018

image

When a demo info is loaded and has markers, the icon becomes green. Markers are also displayed in the info section. It doesn't look amazing but it's functional. We can perhaps do a better job designing this part of the UI later.

Edit: "not loaded" status is now a grey icon.

I also fixed a double click issue (a triple click was needed and even that sometimes didn't work).

@ChillerDragon

This comment has been minimized.

Copy link
Contributor

ChillerDragon commented Dec 21, 2018

Finally a reason to upgrade to 0.7!
Have been waiting years for this feature love you @LordSk <3

Is it possible to sort or order only the demos with markers out? For people like me with millions of demos who sometimes forget to sort out the good ones for weeks.

@LordSk

This comment has been minimized.

Copy link
Member

LordSk commented Dec 21, 2018

@ChillerDragon I'm glad you like it, although there is something I need to clarify.
When you click on a demo item in the list, it gets "loaded" and only then you are able to know the number of markers it contains. A quick way to "load" all demos then is pressing the down arrow key (turning the icon green in the process if it has markers). What you want is slightly but crucially different.
You need to have all the demos already loaded in order to sort/filter them, but loading all of them at once will freeze the screen for a few seconds. We would need to load them asynchronously (in the background) and as far as I know, we currently don't have a system to do that easily.

Short answer: we can't yet.

@Dune-jr

This comment has been minimized.

Copy link
Member

Dune-jr commented Dec 21, 2018

Thanks.

Maybe there should be a naming convention when the client saves a demo to signal the existence of markers. It is somewhat counter-intuitive for anyone who doesn't read the patch notes to have to click on a demo to check for markers if that marker is displayed on the list.

Should it only be shown on the demo details, to not mislead anyone?

@@ -971,7 +983,7 @@ CMenus::CListboxItem CMenus::UiDoListboxNextItem(CListBoxState* pState, const vo
{
pState->m_ListBoxDoneEvents = 1;

if(m_EnterPressed || (UI()->CheckActiveItem(pId) && Input()->MouseDoubleClick()))
if(m_EnterPressed || (UI()->LastActiveItem() == pId && Input()->MouseDoubleClick()))

This comment has been minimized.

@oy

oy Dec 21, 2018

Member

Don't do that. Could lead to a GUI lock.

This comment has been minimized.

@LordSk

LordSk Dec 22, 2018

Member

Ok, fixed.

@ChillerDragon

This comment has been minimized.

Copy link
Contributor

ChillerDragon commented Dec 22, 2018

Imo this searching for demos with markers doesn't have to be asynchronously. It would be nice to press a button somewhere and actually get a freeze maybe even with a nice loading bar / status. Loading multiple of 300min+ demos can take a while and a status would be nice instead of not knowing what is happening in the background.

And yes I can promise you it happens that people leave their client open 24/7 hours multiple days. And rarley switch server/maps probably less likley in vanilla but i think we agreed on supporting mods a bit c:

@oy oy merged commit e21c5d8 into teeworlds:master Dec 22, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@LordSk LordSk deleted the LordSk:feature/demolist_markers branch Dec 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment