Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide past chat of ignored players #2110

Merged
merged 2 commits into from Apr 26, 2019
Merged

Conversation

@Dune-jr
Copy link
Member

Dune-jr commented Apr 24, 2019

I usually ignore players who flood the chat, it would be nice to clear the chat history too. This does not erase the messages from the buffer, so a un-ignore would restore them.

Edit: fixes #1634

if(Line.m_aText[0] == 0)
break;

if(Line.m_ClientID && m_pClient->m_aClients[i].m_ChatIgnore)

This comment has been minimized.

Copy link
@oy

oy Apr 26, 2019

Member

Should check if 'ClientID is >= 0' and then use it as index for the clients, 'i' is line number

This comment has been minimized.

Copy link
@Dune-jr

Dune-jr Apr 26, 2019

Author Member

Thanks, not sure how this didn't show up during testing

@oy
oy approved these changes Apr 26, 2019
@oy oy merged commit f4a18aa into teeworlds:master Apr 26, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Dune-jr Dune-jr deleted the Dune-jr:task-delete-ignored branch Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.