Hide past chat of ignored players #2110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oy
requested changes
Apr 26, 2019
src/game/client/components/chat.cpp
Outdated
| if(Line.m_aText[0] == 0) | ||
| break; | ||
|
|
||
| if(Line.m_ClientID && m_pClient->m_aClients[i].m_ChatIgnore) |
Member
There was a problem hiding this comment.
Should check if 'ClientID is >= 0' and then use it as index for the clients, 'i' is line number
Member
Author
There was a problem hiding this comment.
Thanks, not sure how this didn't show up during testing
oy
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I usually ignore players who flood the chat, it would be nice to clear the chat history too. This does not erase the messages from the buffer, so a un-ignore would restore them.
Edit: fixes #1634