Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide past chat of ignored players #2110

Merged
merged 2 commits into from Apr 26, 2019
Merged

Conversation

Dune-jr
Copy link
Member

@Dune-jr Dune-jr commented Apr 24, 2019

I usually ignore players who flood the chat, it would be nice to clear the chat history too. This does not erase the messages from the buffer, so a un-ignore would restore them.

Edit: fixes #1634

if(Line.m_aText[0] == 0)
break;

if(Line.m_ClientID && m_pClient->m_aClients[i].m_ChatIgnore)
Copy link
Member

@oy oy Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check if 'ClientID is >= 0' and then use it as index for the clients, 'i' is line number

Copy link
Member Author

@Dune-jr Dune-jr Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not sure how this didn't show up during testing

oy
oy approved these changes Apr 26, 2019
@oy oy merged commit f4a18aa into teeworlds:master Apr 26, 2019
3 checks passed
@Dune-jr Dune-jr deleted the task-delete-ignored branch Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants