Added chat buffer, now memorizes chat#2123
Merged
oy merged 5 commits intoteeworlds:masterfrom May 1, 2019
AssassinTee:BufferedChat
Merged
Added chat buffer, now memorizes chat#2123oy merged 5 commits intoteeworlds:masterfrom AssassinTee:BufferedChat
oy merged 5 commits intoteeworlds:masterfrom
AssassinTee:BufferedChat
Conversation
Member
|
It works but there is no way of deleting the whole line other than by pressing Escape, so not being able to do that without changing chat modes is a bit counter-inuititve and clunky. Maybe Escape should keep its behavior and mouse clicks should allow a "soft exit"? Also I don't think messages should survive changing servers. |
Contributor
Author
wip |
Contributor
Author
|
You can now come out of the chat with mouse1 and mouse2 (hook and fire) and your text is buffered and not lost. |
oy
requested changes
May 1, 2019
oy
approved these changes
May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat is memorized, until you send it. If you switch to another chat-mode, the buffer will be cleared