Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added chat buffer, now memorizes chat #2123

Merged
merged 5 commits into from
May 1, 2019
Merged

Added chat buffer, now memorizes chat #2123

merged 5 commits into from
May 1, 2019

Conversation

AssassinTee
Copy link
Contributor

Chat is memorized, until you send it. If you switch to another chat-mode, the buffer will be cleared

@Dune-jr
Copy link
Member

Dune-jr commented May 1, 2019

It works but there is no way of deleting the whole line other than by pressing Escape, so not being able to do that without changing chat modes is a bit counter-inuititve and clunky. Maybe Escape should keep its behavior and mouse clicks should allow a "soft exit"? Also I don't think messages should survive changing servers.

@AssassinTee
Copy link
Contributor Author

AssassinTee commented May 1, 2019

  • Delete buffer when leaving server
  • Use mouse1 instead of Escape for the saving buffer

wip

@AssassinTee
Copy link
Contributor Author

You can now come out of the chat with mouse1 and mouse2 (hook and fire) and your text is buffered and not lost.
The buffer is cleared when disconnecting.

src/game/client/components/chat.cpp Outdated Show resolved Hide resolved
@oy oy merged commit 95f2a6b into teeworlds:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants