Add basic race features #2307

axblk · 2019-12-09T02:29:07Z

This addresses #2172. Included features are:

times in the server browser
times in the scoreboard (and map record at the top)
separate race timer
support for checkpoints
finish message
localized chat message for new records

The server can set a few config params:

accuracy of the displayed times
hide kill messages
finish messages can be displayed like the kill messages or as localized chat messages (depending on how often a finish occurs, you may want to emphasize it more)

For testing this, the two "Race Test" servers already implement this protocol extension.
You can find the code at: https://github.com/axblk/teeworlds/tree/race_proto

This is more of a proposal and I'm open for your opinions and suggestions! 😃
The flag used for the finish messages is from the old client pack. When someone has a better icon, I'll replace it.

The finish messages are a bit smaller now, but these screenshots should show most of the features:

- Times in the scoreboard - Finish messages - Timer - Checkpoints

fokkonaut · 2019-12-09T05:47:19Z

The miliseconds should only show two decimals. And the new timer is very ugly, should merge it with the gametimer or at put it next to it somehow. In scoreboard at the top right, where the best time is should, this shouldnt display the decimals at all, just minutes:seconds

Dune-jr · 2019-12-09T06:40:35Z

Good job ❤️

I think the statboard could be safely disabled in race gamemodes.

For the rest, it's much like the widely enjoyed 0.6 Client Pack.

the timer is just like back then and I think it's good. There used to be a clock icon next to it, actually
you obviously want to see precisely the best time. The screenshot is a good use case: you are less than a second away from best time.

--- edit ---
The fading checkpoints look nice and I enjoy the choice of colors for info messages & checkpoints.

fokkonaut · 2019-12-09T05:52:46Z

src/game/client/components/hud.cpp

@@ -153,7 +155,11 @@ void CHud::RenderScoreHud()
 		float Whole = 300*Graphics()->ScreenAspect();
 		float StartY = 229.0f;

-		if(GameFlags&GAMEFLAG_TEAMS && m_pClient->m_Snap.m_pGameDataTeam)
+		if(GameFlags&GAMEFLAG_RACE)


what does this do?

For now it disables the HUD in the lower right corner. It could maybe just display the fastest player. Any other suggestion what to display here?

How about your own fastest time and the fastest one in general?

It works like in DM now. When you are in spec the two fastest players on the server are shown. Otherwise it displays you and the fastest player.

fokkonaut · 2019-12-09T09:39:17Z

I think the statboard could be safely disabled in race gamemodes.

I wouldnt do that. My mod for example is based on DDrace but also supports kills, deaths and flags.

LordSk · 2019-12-09T11:46:53Z

Good job as usual 👍 .
I think it is overall a good addition to teeworlds, as it adds only the essential parts to a race gametype.

axblk · 2019-12-09T11:58:21Z

@fokkonaut as stated in the initial post you can configure how many decimals are used for the times. In fastcap for example you want to have milliseconds everywhere. There are maps where the record is around 3 seconds.

The timer is probably what you are used to. When I replaced the game timer with the race timer in the client pack, people complained that I should bring the old timer back.

fokkonaut · 2019-12-09T12:41:28Z

Maybe make it configurable aswell, as you already made some things as configs

axblk · 2019-12-09T15:24:10Z

I consider to change two more things:

Add an option to not reset the wanted weapon on death. Auto switch weapon on pickup is sometimes too slow since it is client-side. Moving it to the server would require even more protocol additions. The easier solution is to select the wanted weapon before you start the race, however it is easier when the wanted weapon is kept after death.
Add a client side variable to configure the timer (separate or as a replacement for the game timer). While the other options are server-side (and hardcoded), the player should be able to configure this himself.

oy · 2019-12-09T18:32:36Z

Good job 👍
Don't think that the game timer should be replaced by the race timer. General features should be consistent between gametypes. And when there's a timelimit on the server you need that countdown.
Maybe add a graphical icon to the race timer to make it stand out some more?
[On a different note if that's the place for the race timer that same place should probably be used for survival gametypes to show remaining players.]

AssassinTee · 2019-12-09T19:14:40Z

Note: the auto pickup should be serversided, it's just a flag for the client and very easy to implement, could be in the connect message

axblk · 2019-12-09T21:35:51Z

Then I'll leave the game timer thing to custom clients 👍
An icon for the timer would be cool. Actually the only icon I have is the one from #2172 (comment). I'd prefer to use another one.

Just adding flags to the network protocol is not that easy. Doing it in the engine protocol (e.g. the connect message) would work, but it just does not belong there. Adding things to the existing game messages will not work since old servers would just drop the packets. The only non-hacky solution would be to add even more net messages.

Dune-jr · 2019-12-11T21:47:12Z

Throwback to 2010 for the sake of it:

If I recall correctly, this was SushiTee's work, maybe with some (poor taste) tweaks.

oy · 2019-12-13T15:17:06Z

@Sonix- @Zatline
This needs a better flag icon for the finish message, the actual one is too detailed and doesn't render that good.

axblk · 2019-12-13T19:37:26Z

One thing I forgot to mention: a lot of this is based on the 0.6 client-pack from SushiTee 😃

Current state with some UI tweaks and the icon from Sonix:

axblk added 10 commits December 9, 2019 02:47

Extend network protocol for basic race features

d4c3b11

Show times in the serverbrowser

3e186b5

Replace kill messages with time messages in race gamemodes

b743193

Add more race features

eee1e8f

- Times in the scoreboard - Finish messages - Timer - Checkpoints

Add minimal client version for race features

eccf470

Fix snapshot delta for new items

22b3dba

Merge kill and finish messages

fd555a2

Add localized chat message for new race records

d217838

Race: add possibility to hide kill messages

cd12115

Race: add possibility to print finishes in chat

374957c

fokkonaut reviewed Dec 9, 2019

View reviewed changes

axblk closed this Dec 9, 2019

axblk reopened this Dec 9, 2019

axblk added 2 commits December 9, 2019 15:54

Filter out GAMEFLAG_RACE for unsupported clients

1381a2b

Clean up race precision handling

adfde95

Add race score hud

6774be0

axblk added 2 commits December 13, 2019 19:36

Add race flag for keeping the wanted weapon on death

a481f3d

Add timer clock icon by Sonix

38310aa

axblk added 2 commits December 13, 2019 19:37

Improve race hud a bit

657df82

Some more race ui tweaks

b9b3524

oy merged commit 8cdd0da into teeworlds:master Dec 14, 2019

axblk deleted the feature/race branch December 14, 2019 16:12

axblk mentioned this pull request Jun 16, 2020

Auto demo recording for race axblk/teeworlds#27

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic race features #2307

Add basic race features #2307

axblk commented Dec 9, 2019

fokkonaut commented Dec 9, 2019

Dune-jr commented Dec 9, 2019 •

edited

Loading

fokkonaut Dec 9, 2019

axblk Dec 9, 2019

oy Dec 9, 2019

axblk Dec 9, 2019

fokkonaut commented Dec 9, 2019 •

edited

Loading

LordSk commented Dec 9, 2019

axblk commented Dec 9, 2019 •

edited

Loading

fokkonaut commented Dec 9, 2019

axblk commented Dec 9, 2019 •

edited

Loading

oy commented Dec 9, 2019

AssassinTee commented Dec 9, 2019

axblk commented Dec 9, 2019

Dune-jr commented Dec 11, 2019

oy commented Dec 13, 2019

axblk commented Dec 13, 2019

Add basic race features #2307

Add basic race features #2307

Conversation

axblk commented Dec 9, 2019

fokkonaut commented Dec 9, 2019

Dune-jr commented Dec 9, 2019 • edited Loading

fokkonaut Dec 9, 2019

Choose a reason for hiding this comment

axblk Dec 9, 2019

Choose a reason for hiding this comment

oy Dec 9, 2019

Choose a reason for hiding this comment

axblk Dec 9, 2019

Choose a reason for hiding this comment

fokkonaut commented Dec 9, 2019 • edited Loading

LordSk commented Dec 9, 2019

axblk commented Dec 9, 2019 • edited Loading

fokkonaut commented Dec 9, 2019

axblk commented Dec 9, 2019 • edited Loading

oy commented Dec 9, 2019

AssassinTee commented Dec 9, 2019

axblk commented Dec 9, 2019

Dune-jr commented Dec 11, 2019

oy commented Dec 13, 2019

axblk commented Dec 13, 2019

Dune-jr commented Dec 9, 2019 •

edited

Loading

fokkonaut commented Dec 9, 2019 •

edited

Loading

axblk commented Dec 9, 2019 •

edited

Loading

axblk commented Dec 9, 2019 •

edited

Loading