New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't mark as viewed #2

Closed
freijon opened this Issue Sep 7, 2015 · 13 comments

Comments

Projects
None yet
4 participants
@freijon
Copy link

freijon commented Sep 7, 2015

After successfully scrobbling an episode/movie to trakt.tv for the full length of the video, the episode/movie doesn't get marked as "viewed". I have to manually mark the episoded I watched.

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Sep 7, 2015

Could you provide more details on this? I tested an episode here and it got marked as watched correctly.
When you started watching, Trakt displayed the progress? Did you see any errors on console? This happened with a episode in particular or with anything you watched?

@freijon

This comment has been minimized.

Copy link

freijon commented Sep 8, 2015

I watched several BoJack Horseman episodes. On my profile on Trakt it showed me the progress correclty. What might cause the problem is that I'm watching with Chromecast. But again, the progressbar on Trakt shows the correct information and the Traktflix logo turns red when playing and when I click the button it shows me the correct episode. Haven't checked the console, I'll try that in the evening.

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Sep 8, 2015

Never tested with a chromecast, but if the progress showed on trakt, the scrobble started correctly. The issue may be on the stop step. Can you tell me where you clicked? (Back to browse, next episode, etc)

@freijon

This comment has been minimized.

Copy link

freijon commented Sep 8, 2015

I either clicked on the "stacked window" symbol in the player where you can choose between episodes or I did nothing at all (let the episode run out). When connected to the Chromecast it then jumps to the main Netflix homepage. I'll now test how it behaves when I watch an episode on my laptop without the Chromecast.

EDIT: "normally" watching it on my laptop also didn't mark the episode as watched.

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Sep 8, 2015

Clicking on other episode on stacked window worked correctly, but letting the episode run out to another, there I found an issue. I am listening to popstate, so the scrobble pauses when the page backs to navigation, but in this case only the querystring change in the url. I'll see what I can do to fix this.
Thank you for reporting this bug!

@tegon tegon added the bug label Sep 8, 2015

@tegon tegon closed this in 336fac2 Sep 15, 2015

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Sep 15, 2015

Fixed on v1.0.4.4573

@skotsjedal

This comment has been minimized.

Copy link

skotsjedal commented Sep 17, 2015

I have this issue still, correctly tracks "now playing" but at the end, wether I let it run to the next episode, or if I click back to browse or the x when it's waiting for the next episode. It never permanently tracks it. No Chromecast involved

edit: clicking back while still playing (during end credits) did update correctly

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Sep 18, 2015

Are you using last version? Also, can you tell me if are any erros on console?
The stop action should be called whenever an episode or movie ends, either by clicking on other links or if another episode starts. You can se on network tab in chrome developer tools, like in this screenshot:
screenshot 2015-09-18 09 46 25
The progress must be at least 80% to trakt consider it as "watched".
Could you check in your developer tools what is happening?

@skotsjedal

This comment has been minimized.

Copy link

skotsjedal commented Sep 20, 2015

version 1.0.4.4574
Watched something just now, epose was showing underway on trakt.tv but it didn't record the first episode (didn't have console open when it changed, opened it after and no errors). Let the next episode play though, that one did record.

@skotsjedal

This comment has been minimized.

Copy link

skotsjedal commented Sep 20, 2015

Tried again, it sends a stop but progress is only 76.61 although I watched it all from start to finish

start

{"episode":{"season":4,"number":12,"title":"Campaign Ad","ids":{"trakt":406268,"tvdb":4200379,"imdb":null,"tmdb":397684,"tvrage":null},"images":{"screenshot":{"full":"https://walter.trakt.us/images/episodes/000/406/268/screenshots/original/60d5730a42.jpg","medium":"https://walter.trakt.us/images/episodes/000/406/268/screenshots/medium/60d5730a42.jpg","thumb":"https://walter.trakt.us/images/episodes/000/406/268/screenshots/thumb/60d5730a42.jpg"}}},"progress":0.04}

stop

{"episode":{"season":4,"number":12,"title":"Campaign Ad","ids":{"trakt":406268,"tvdb":4200379,"imdb":null,"tmdb":397684,"tvrage":null},"images":{"screenshot":{"full":"https://walter.trakt.us/images/episodes/000/406/268/screenshots/original/60d5730a42.jpg","medium":"https://walter.trakt.us/images/episodes/000/406/268/screenshots/medium/60d5730a42.jpg","thumb":"https://walter.trakt.us/images/episodes/000/406/268/screenshots/thumb/60d5730a42.jpg"}}},"progress":76.61}

start on next episode

{"episode":{"season":4,"number":13,"title":"Bowling for Votes","ids":{"trakt":406269,"tvdb":4204799,"imdb":null,"tmdb":397682,"tvrage":null},"images":{"screenshot":{"full":"https://walter.trakt.us/images/episodes/000/406/269/screenshots/original/4d8d72c3c0.jpg","medium":"https://walter.trakt.us/images/episodes/000/406/269/screenshots/medium/4d8d72c3c0.jpg","thumb":"https://walter.trakt.us/images/episodes/000/406/269/screenshots/thumb/4d8d72c3c0.jpg"}}},"progress":null}
@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Sep 21, 2015

The progress comes from the player progress bar width, basically this code:

document.getElementsByClassName('player-scrubber-progress-completed')[0].style.width

Is there any chances that the episode you watched went to the credits too soon?

@112358z

This comment has been minimized.

Copy link

112358z commented Jan 30, 2016

I am facing this issue currently.

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Jan 30, 2016

Can you provide more info like the ones above?

tegon added a commit that referenced this issue Dec 27, 2018

Firefox compatibility and many improvements (#89)
* - Make extension compatible with Firefox
- Improve episode title detection

* Update extension.zip

* - Migrate to Webpack
- Add options menu
- Various fixes and improvements

* - Many bug fixes and enhancements
- Add PT-BR locale
- Fix tests
- Up version

* Update README.md

* - Fix collections detection

* Update README.md

* - Use Netflix API instead of scraping the HTML (close #1)

* - Improve loading time of activity history (closes #2)

* - Fix webpack.config

* - Rename config.json.dev to config.dev.json

* - Add Firefox to .travis.yml

* - Possible fix for Travis

* - Implement cache and database for history sync (close #3)
- Add option to disable scrobbling (close #4)

* - Improve error handling when updating item in history sync (close #5)

* - Make requests to the Netflix API using English (close #7)
- Disable sync checkbox if item was not found on Trakt (close #8)
- Make sure that when 'Select all' is toggled, items that are disabled are not checked (close #9)

* - v2.0.1

* - Fix a bug that only triggers the extension when installing/updating on Firefox (close #10)
- Migrate tests from Jasmine to Mocha + Chai (close #11)
- v2.0.2

* v2.0.3

* v2.0.4

-  Fix a bug that happens when updating shows (close #14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment