New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Chromecast support #8

Closed
freijon opened this Issue Oct 18, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@freijon
Copy link

freijon commented Oct 18, 2015

Chromecasts only work partially at the moment. When starting an episode with the normal player and then switching to Chromecast mode, it continues scrobbling (the icon is red). However, when switching episodes (while still in Chromecast mode) it behaves like you stop the episode.

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Oct 19, 2015

Unfortunately, I won't be able to hack into this, since I don't have a chromecast. But I will be happy to accept a PR.

@freijon

This comment has been minimized.

Copy link

freijon commented Oct 19, 2015

I'll take a look at the code and try to figure out how it works. JS is new for me.

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Nov 4, 2015

Just borrowed a chromecast from a friend, can you explain better what is happening?

@freijon

This comment has been minimized.

Copy link

freijon commented Nov 4, 2015

When I start watching, I usually start the episode with the web player and then when it's already running/scrobbling I start streaming to the chromecast. Scrobbling continues to work when finishing this episode. But when I switch episodes (stacked window symbol) when streaming to the chromecast, Traktflix doesn't detect that a new episode is playing. Sometimes when I click the Traktflix icon it shows the correct episode name but still doesn't scrobble. Haven't figured out yet what the behavior is exactly. Let me know if I can assist in any way.

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Nov 10, 2015

Looks like I've found the issue. I'm checking for a url change with location.pathname. But when in the cast mode, Netflix only changes the url's hash. I'll came up with a solution soon.

@tegon tegon added the bug label Nov 10, 2015

@tegon tegon closed this in c4e107c Nov 10, 2015

tegon added a commit that referenced this issue Dec 27, 2018

Firefox compatibility and many improvements (#89)
* - Make extension compatible with Firefox
- Improve episode title detection

* Update extension.zip

* - Migrate to Webpack
- Add options menu
- Various fixes and improvements

* - Many bug fixes and enhancements
- Add PT-BR locale
- Fix tests
- Up version

* Update README.md

* - Fix collections detection

* Update README.md

* - Use Netflix API instead of scraping the HTML (close #1)

* - Improve loading time of activity history (closes #2)

* - Fix webpack.config

* - Rename config.json.dev to config.dev.json

* - Add Firefox to .travis.yml

* - Possible fix for Travis

* - Implement cache and database for history sync (close #3)
- Add option to disable scrobbling (close #4)

* - Improve error handling when updating item in history sync (close #5)

* - Make requests to the Netflix API using English (close #7)
- Disable sync checkbox if item was not found on Trakt (close #8)
- Make sure that when 'Select all' is toggled, items that are disabled are not checked (close #9)

* - v2.0.1

* - Fix a bug that only triggers the extension when installing/updating on Firefox (close #10)
- Migrate tests from Jasmine to Mocha + Chai (close #11)
- v2.0.2

* v2.0.3

* v2.0.4

-  Fix a bug that happens when updating shows (close #14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment