New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to page_action instad of browser_action #3

Merged
merged 3 commits into from Sep 22, 2015

Conversation

Projects
None yet
2 participants
@MrMamen
Copy link
Contributor

MrMamen commented Sep 21, 2015

Since it only works on a single site, it is better to use page_action

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Sep 22, 2015

Wow I didn't knew about page_action, it really makes sense.
Could you make some changes? This is more for maintain the code style.

  • Remove the spaces in functions declarations, e.g.
chrome.runtime.onInstalled.addListener(function() {

instead of

chrome.runtime.onInstalled.addListener(function () {
  • Add spaces in objects declarations, e.g.
new chrome.declarativeContent.PageStateMatcher({
  pageUrl: { hostSuffix: 'netflix.com' }
})

instead of

new chrome.declarativeContent.PageStateMatcher({
  pageUrl: {hostSuffix: 'netflix.com'}
})

I'm planning to add something like jscsrc to make this automatically.
Thanks for the contribution, I appreciate. As soon as you make this changes, I'll merge it.

@MrMamen

This comment has been minimized.

Copy link
Contributor

MrMamen commented Sep 22, 2015

I've updated Editor Code Style in my IDE to better match the style of your code.

tegon added a commit that referenced this pull request Sep 22, 2015

Merge pull request #3 from MrMamen/master
Switch to page_action instad of browser_action

@tegon tegon merged commit a5e35d0 into tegon:master Sep 22, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.26%
Details

tegon added a commit that referenced this pull request Dec 27, 2018

Firefox compatibility and many improvements (#89)
* - Make extension compatible with Firefox
- Improve episode title detection

* Update extension.zip

* - Migrate to Webpack
- Add options menu
- Various fixes and improvements

* - Many bug fixes and enhancements
- Add PT-BR locale
- Fix tests
- Up version

* Update README.md

* - Fix collections detection

* Update README.md

* - Use Netflix API instead of scraping the HTML (close #1)

* - Improve loading time of activity history (closes #2)

* - Fix webpack.config

* - Rename config.json.dev to config.dev.json

* - Add Firefox to .travis.yml

* - Possible fix for Travis

* - Implement cache and database for history sync (close #3)
- Add option to disable scrobbling (close #4)

* - Improve error handling when updating item in history sync (close #5)

* - Make requests to the Netflix API using English (close #7)
- Disable sync checkbox if item was not found on Trakt (close #8)
- Make sure that when 'Select all' is toggled, items that are disabled are not checked (close #9)

* - v2.0.1

* - Fix a bug that only triggers the extension when installing/updating on Firefox (close #10)
- Migrate tests from Jasmine to Mocha + Chai (close #11)
- v2.0.2

* v2.0.3

* v2.0.4

-  Fix a bug that happens when updating shows (close #14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment