Skip to content

/ ash

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic crow support #3

Merged
merged 2 commits into from Oct 5, 2019
Merged

basic crow support #3

merged 2 commits into from Oct 5, 2019

Conversation

@pq
Copy link
Contributor

@pq pq commented Oct 1, 2019

quick hack; feel free to ignore or incorporate 👍

/cc @tehn
pq added 2 commits Oct 1, 2019
@pq
basic crow support
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
738b9a5
@pq
inline props
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
661e7a1
@tehn
tehn reviewed Oct 1, 2019
View changes
Copy link
Owner

@tehn tehn left a comment

looks fantastic! did all three methods test ok?
@pq
Copy link
Contributor Author

@pq pq commented Oct 1, 2019

audio and jf for sure. crow 1+2 i can confirm cv on 1... (i just cribbed it from awake); let me play a little more and update.
@pq
Copy link
Contributor Author

@pq pq commented Oct 1, 2019

ok, confirmed crow 1+2. would be nice to make the output action on cv 2 configurable but i'm not quite sure how folks would want to do it. more params?
@tehn tehn merged commit b4f6ea2 into tehn:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehn tehn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@pq @tehn