Save patterns add pan #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2019 04:04
- added pattern saving by breaking out length/start/data as parameters for each pattern - add pan parameter to engine - add pan, delay_pan parameters to script, halfsecond
GoneCaving
reviewed
Nov 11, 2019
| local midi_out_device | ||
| local midi_out_channel | ||
|
|
||
| local scale_names = {} | ||
| notes = {} | ||
| local notes = {} | ||
| local active_notes = {} | ||
|
|
||
| local edit_ch = 1 | ||
| local edit_pos = 1 | ||
|
|
||
| snd_sel = 1 |
There was a problem hiding this comment.
Should this also be local?
There was a problem hiding this comment.
actually, with recent changes to reset global enviroment between scripts (monome/norns#929), better practice would be to make none of these top-level variables local! (they will be nuked when the next script is launched, and keeping them global makes them accessible from maiden REPL.) so, my bad.
i think all the "common" patches need a good cleanup to bring in line with current recommended best practices.
(e.g. in this script, the declaration of control specs is probably redundant.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added pattern saving by the caveman method of breaking out all pattern data as parameters.
also added separate pan parameters for engine and softcut