Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save patterns add pan #6
Save patterns add pan #6
Changes from all commits
e5a7027b0a9e90File filter...
Jump to…
GoneCavingNov 11, 2019
Contributor
Should this also be local?
catfactNov 12, 2019
Author
Contributor
actually, with recent changes to reset global enviroment between scripts (monome/norns#929), better practice would be to make none of these top-level variables local! (they will be nuked when the next script is launched, and keeping them global makes them accessible from maiden REPL.) so, my bad.
i think all the "common" patches need a good cleanup to bring in line with current recommended best practices.
(e.g. in this script, the declaration of control specs is probably redundant.)