Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When loading clips only stop track playback if a new clip is actually selected #18

Closed
etherbrooklyn opened this issue Nov 18, 2019 · 1 comment

Comments

@etherbrooklyn
Copy link

@etherbrooklyn etherbrooklyn commented Nov 18, 2019

For discussion and consideration.

Current behaviour is to immediately stop track playback when KEY2 is pressed, with no way to cancel and leave track playing (e.g. if KEY2 was mistakenly pressed).

Better behaviour would be to only stop track if KEY2 is pressed, then a valid audio file actually selected and successfully loaded into the relevant buffer.

@tehn
Copy link
Owner

@tehn tehn commented Nov 18, 2019

this description is a little off, but i fixed the problem.

clips were stopped on clip position select, even if you re-selected the existing position.
works more as expected now. updated.

6b55718..1e52477

@tehn tehn closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants