Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research: Polyfill / Shim to get storage events to work correctly on IE8 #6

Closed
tejacques opened this issue Nov 7, 2014 · 1 comment

Comments

@tejacques
Copy link
Owner

There are a few implementations of such shims available on the internet, but it's not clear to me whether there can be data lost due to race conditions. If there is a way of shimming this on IE8 in a way that is fully compliant and not subject to race conditions then it we should support and test that shim.

@tejacques tejacques changed the title Research: Polyfilll / Shim to get storage events to work correctly on IE8 Research: Polyfill / Shim to get storage events to work correctly on IE8 Nov 8, 2014
@tejacques
Copy link
Owner Author

I created a polyfill for this with some help from @Sidnicious based off of Johnathan Neal's https://github.com/jonathantneal/EventListener / Financial Times https://github.com/Financial-Times/polyfill-service/blob/master/polyfills/Event. It is located at https://github.com/tejacques/IE8-EventListener.

There is a small tweak that needs to be made in order for crosstab to work with it, which is to use var storage = storage || window.localStorage instead of localStorage for setting items in localStorage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant