Neo2 Fixes #40

Closed
christophebeling opened this Issue Sep 21, 2016 · 30 comments

Comments

Projects
None yet
10 participants
@christophebeling

I would like to use karabiner to configure neo2 for macOS sierra. Unfortunately i can not find the config options for the json. http://wiki.neo-layout.org/wiki/Neo%20auf%20dem%20Apple%20Macintosh%20einrichten

Any help would be highly appreciated.

@neominik

This comment has been minimized.

Show comment
Hide comment
@neominik

neominik Sep 21, 2016

I am trying to port the old neo2 configuration to json too.
Unfortunately there are still some features missing here.
It can map from one key to another atm.
This is not enough to map the 4th and 6th layer.

At least you can get layer 3 working with the following karabiner.json:

{
    "profiles": [
        {
            "name": "Default profile",
            "selected": true,
            "simple_modifications": {
                "caps_lock": "right_option",
                "backslash": "right_option"
            }
        }
    ]
}

neominik commented Sep 21, 2016

I am trying to port the old neo2 configuration to json too.
Unfortunately there are still some features missing here.
It can map from one key to another atm.
This is not enough to map the 4th and 6th layer.

At least you can get layer 3 working with the following karabiner.json:

{
    "profiles": [
        {
            "name": "Default profile",
            "selected": true,
            "simple_modifications": {
                "caps_lock": "right_option",
                "backslash": "right_option"
            }
        }
    ]
}
@pfitz

This comment has been minimized.

Show comment
Hide comment
@pfitz

pfitz Sep 22, 2016

Really would like to see better and more complex examples and/or a reference to make more complex configs.

pfitz commented Sep 22, 2016

Really would like to see better and more complex examples and/or a reference to make more complex configs.

@pfitz

This comment has been minimized.

Show comment
Hide comment
@pfitz

pfitz Sep 22, 2016

@neominik I tried this config and it does nothing for me. how did you installed it?

Disregard: Had a wrong filename 😱

pfitz commented Sep 22, 2016

@neominik I tried this config and it does nothing for me. how did you installed it?

Disregard: Had a wrong filename 😱

@nonec

This comment has been minimized.

Show comment
Hide comment
@nonec

nonec Sep 23, 2016

This works fine for me:

{
    "profiles": [
        {
            "name": "Neo Layout",
            "selected": true,
            "simple_modifications": {
                "caps_lock": "left_option",
                "non_us_pound": "right_option"
            }
        }
    ]
}

nonec commented Sep 23, 2016

This works fine for me:

{
    "profiles": [
        {
            "name": "Neo Layout",
            "selected": true,
            "simple_modifications": {
                "caps_lock": "left_option",
                "non_us_pound": "right_option"
            }
        }
    ]
}
@PaulePan

This comment has been minimized.

Show comment
Hide comment
@PaulePan

PaulePan Sep 27, 2016

I hope that there will be a solution for Layer 4/6. I think we have to wait for final Version of Karabiner Elements.

I hope that there will be a solution for Layer 4/6. I think we have to wait for final Version of Karabiner Elements.

@fabyeah

This comment has been minimized.

Show comment
Hide comment
@fabyeah

fabyeah Nov 9, 2016

Level 4 isn't working yet, is it? :(

Or has anyone managed to make it work? Is there a workaround or another tool to achieve this?

fabyeah commented Nov 9, 2016

Level 4 isn't working yet, is it? :(

Or has anyone managed to make it work? Is there a workaround or another tool to achieve this?

@tjanson

This comment has been minimized.

Show comment
Hide comment
@tjanson

tjanson Nov 9, 2016

tjanson commented Nov 9, 2016

@alteroppa

This comment has been minimized.

Show comment
Hide comment

+1

@SirVer

This comment has been minimized.

Show comment
Hide comment
@SirVer

SirVer Jan 13, 2017

+1 - I would like to support this somehow, preferably with money. Can I donate somewhere to give this bug priority?

SirVer commented Jan 13, 2017

+1 - I would like to support this somehow, preferably with money. Can I donate somewhere to give this bug priority?

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 13, 2017

I'm working on a implementation of the Neo2 layout over here. Actually I'm mostly finished on the implementation side, I just have to do some more testing and add some installation instructions. Unfortunately, you will have to compile (and sign) that version yourself right now because I don't have an Apple Developer account that would allow me to create a redistributable package.

I'm working on a implementation of the Neo2 layout over here. Actually I'm mostly finished on the implementation side, I just have to do some more testing and add some installation instructions. Unfortunately, you will have to compile (and sign) that version yourself right now because I don't have an Apple Developer account that would allow me to create a redistributable package.

@SirVer

This comment has been minimized.

Show comment
Hide comment
@SirVer

SirVer Jan 16, 2017

@jgosmann That is very awesome! Will this be merged back into the main repo? How can I help testing this?

SirVer commented Jan 16, 2017

@jgosmann That is very awesome! Will this be merged back into the main repo? How can I help testing this?

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 16, 2017

I have no plans at the moment to get this in a state where it would be merged back into the main repo. Many of the layer 4 keys are hard coded which would not be acceptable in the main release.

As for testing: Install it and see if the layout including layer 4/6 works? (I haven't written the compile and install documentation yet, hopefully I manage this weekend.)

I have no plans at the moment to get this in a state where it would be merged back into the main repo. Many of the layer 4 keys are hard coded which would not be acceptable in the main release.

As for testing: Install it and see if the layout including layer 4/6 works? (I haven't written the compile and install documentation yet, hopefully I manage this weekend.)

@SirVer

This comment has been minimized.

Show comment
Hide comment
@SirVer

SirVer Jan 17, 2017

@jgosmann Could you ping this bug once you have outlined the installation process somewhere? I have for example no experience to sign a kernel extension, so I would not know how to install this.

Also, could you write a few lines of what cleanup would be needed to get this merged back into master? It would be a shame if you effectively fork this and people in the future would need to choose between your Neo port (which probably did not receive latest bug fixes since you moved on) and upstream. Not suggesting that you should do the cleanups (you did plenty by making Neo work!), but only you know what would be required. So writing something down gives somebody else a chance to do the work.

SirVer commented Jan 17, 2017

@jgosmann Could you ping this bug once you have outlined the installation process somewhere? I have for example no experience to sign a kernel extension, so I would not know how to install this.

Also, could you write a few lines of what cleanup would be needed to get this merged back into master? It would be a shame if you effectively fork this and people in the future would need to choose between your Neo port (which probably did not receive latest bug fixes since you moved on) and upstream. Not suggesting that you should do the cleanups (you did plenty by making Neo work!), but only you know what would be required. So writing something down gives somebody else a chance to do the work.

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 17, 2017

Could you ping this bug once you have outlined the installation process somewhere?

Will do.

Also, could you write a few lines of what cleanup would be needed to get this merged back into master?

I think the main part would be a way to to allow to configure remappings from a key + a set of modifier key to a different key + a different set of modifier keys. Then the Neo2 remappings need to be moved from the source code to that config file. Probably is is also necessary to do some cleanup of the actual code doing the remapping; it is a little bit hacked in now (partially because I'm not really familiar with the code base).

Could you ping this bug once you have outlined the installation process somewhere?

Will do.

Also, could you write a few lines of what cleanup would be needed to get this merged back into master?

I think the main part would be a way to to allow to configure remappings from a key + a set of modifier key to a different key + a different set of modifier keys. Then the Neo2 remappings need to be moved from the source code to that config file. Probably is is also necessary to do some cleanup of the actual code doing the remapping; it is a little bit hacked in now (partially because I'm not really familiar with the code base).

@SirVer

This comment has been minimized.

Show comment
Hide comment
@SirVer

SirVer Jan 17, 2017

Cool, thanks. I will wait for your installation guidance and then test this.

SirVer commented Jan 17, 2017

Cool, thanks. I will wait for your installation guidance and then test this.

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 21, 2017

I've put the installation and build instructions online. Please test them and let me know if anything doesn't work or I skipped something.

I've put the installation and build instructions online. Please test them and let me know if anything doesn't work or I skipped something.

@christophebeling

This comment has been minimized.

Show comment
Hide comment
@christophebeling

christophebeling Jan 25, 2017

well, for building this you need an apple developer license wich costs 99 $ per year, don't you? can anyone here maybe upload a compiled version?

well, for building this you need an apple developer license wich costs 99 $ per year, don't you? can anyone here maybe upload a compiled version?

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 25, 2017

You don't need a developer license if you build and run it on your own Mac. You only need the developer license if you want to distribute the build package and have it run on other people's Macs. That's why I can't distribute a compiled version at the moment.

You don't need a developer license if you build and run it on your own Mac. You only need the developer license if you want to distribute the build package and have it run on other people's Macs. That's why I can't distribute a compiled version at the moment.

@SirVer

This comment has been minimized.

Show comment
Hide comment
@SirVer

SirVer Jan 25, 2017

@jgosmann Thank you for putting the documentation up. I tried following the build instructions, but in step 3

Click the “Create” buttons next to “Developer ID Application” and “Developer ID Installer”

Those buttons are greyed out for me. The only things I can "create" is iOs Development and Mac development. Is this expected? How can I change this?

Otherwise, the build seems to have been successful, beside the signing of course. Full output is in this gist.

SirVer commented Jan 25, 2017

@jgosmann Thank you for putting the documentation up. I tried following the build instructions, but in step 3

Click the “Create” buttons next to “Developer ID Application” and “Developer ID Installer”

Those buttons are greyed out for me. The only things I can "create" is iOs Development and Mac development. Is this expected? How can I change this?

Otherwise, the build seems to have been successful, beside the signing of course. Full output is in this gist.

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 25, 2017

I might have remembered incorrectly which buttons I clicked. Can you try the “create” button next to “Mac development”?

Otherwise, the build seems to have been successful, beside the signing of course.

Unfortunately, I don't think the required kernel module will be loaded without being signed.

I might have remembered incorrectly which buttons I clicked. Can you try the “create” button next to “Mac development”?

Otherwise, the build seems to have been successful, beside the signing of course.

Unfortunately, I don't think the required kernel module will be loaded without being signed.

@SirVer

This comment has been minimized.

Show comment
Hide comment
@SirVer

SirVer Jan 25, 2017

Partial success here. It seems that it properly codesigns the binaries, but not the package:

code sign Library/Application Support/org.pqrs/Karabiner-Elements/updater/Karabiner-Elements.app/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupdate.app
code sign Library/Application Support/org.pqrs/Karabiner-Elements/updater/Karabiner-Elements.app
code sign Library/Application Support/org.pqrs/Karabiner-Elements/bin/karabiner_grabber
code sign Library/Application Support/org.pqrs/Karabiner-Elements/bin/karabiner_event_dispatcher
code sign Library/Application Support/org.pqrs/Karabiner-Elements/bin/karabiner_console_user_server
code sign Applications/Karabiner-EventViewer.app
code sign Applications/Karabiner-Elements.app

but later

Sign with Developer ID
productsign: error: Could not find appropriate signing identity for “D497CAAC851FC0B463D7D33B87D09CF169C6B3CD”.
Make Archive

Full output: https://gist.github.com/SirVer/ddcd707e255f9b1409e4413a118b87a3

I will try to install this tomorrow. @jgosmann, Any more ideas on the package codesign error?

SirVer commented Jan 25, 2017

Partial success here. It seems that it properly codesigns the binaries, but not the package:

code sign Library/Application Support/org.pqrs/Karabiner-Elements/updater/Karabiner-Elements.app/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupdate.app
code sign Library/Application Support/org.pqrs/Karabiner-Elements/updater/Karabiner-Elements.app
code sign Library/Application Support/org.pqrs/Karabiner-Elements/bin/karabiner_grabber
code sign Library/Application Support/org.pqrs/Karabiner-Elements/bin/karabiner_event_dispatcher
code sign Library/Application Support/org.pqrs/Karabiner-Elements/bin/karabiner_console_user_server
code sign Applications/Karabiner-EventViewer.app
code sign Applications/Karabiner-Elements.app

but later

Sign with Developer ID
productsign: error: Could not find appropriate signing identity for “D497CAAC851FC0B463D7D33B87D09CF169C6B3CD”.
Make Archive

Full output: https://gist.github.com/SirVer/ddcd707e255f9b1409e4413a118b87a3

I will try to install this tomorrow. @jgosmann, Any more ideas on the package codesign error?

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 25, 2017

There will remain some elements that cannot be signed which is fine. However, in your case nothing seems to be signed as there is the following error multiple times:

D497CAAC851FC0B463D7D33B87D09CF169C6B3CD: no identity found

I think you missed step 4 of the build instructions because the ID is my the one of my key.

There will remain some elements that cannot be signed which is fine. However, in your case nothing seems to be signed as there is the following error multiple times:

D497CAAC851FC0B463D7D33B87D09CF169C6B3CD: no identity found

I think you missed step 4 of the build instructions because the ID is my the one of my key.

@SirVer

This comment has been minimized.

Show comment
Hide comment
@SirVer

SirVer Jan 25, 2017

@jgosmann My apologizes, I relinked the first gist again. I am not having my best day today :/. The correct one is https://gist.github.com/SirVer/1be4e5c16284b8b53931ac92eba8ffc4.

SirVer commented Jan 25, 2017

@jgosmann My apologizes, I relinked the first gist again. I am not having my best day today :/. The correct one is https://gist.github.com/SirVer/1be4e5c16284b8b53931ac92eba8ffc4.

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 25, 2017

I think that might be fine. It seems only the installer could not be signed which should be ok (as long as you don't want to distribute it to other people). So I'd suggest to install it and see if it works.

I think that might be fine. It seems only the installer could not be signed which should be ok (as long as you don't want to distribute it to other people). So I'd suggest to install it and see if it works.

@SirVer

This comment has been minimized.

Show comment
Hide comment
@SirVer

SirVer Jan 26, 2017

The package did install without any problems and the other layers are working on my laptop again. I will upgrade my Mac now from El Capitan and see if it still works. I will report any further issues in this bug.

@jgosmann Your build instructions and installation information are correct and working. Thanks again for putting this together.

@christophebeling I can confirm that no payed developer license is needed for the instructions.

@tekezo Neo2 is a popular keymap in Germany and having it supported will benefit karabiner-elements popularity. Could you offer your opinions on upstreaming Jan's changes into the master branch?

SirVer commented Jan 26, 2017

The package did install without any problems and the other layers are working on my laptop again. I will upgrade my Mac now from El Capitan and see if it still works. I will report any further issues in this bug.

@jgosmann Your build instructions and installation information are correct and working. Thanks again for putting this together.

@christophebeling I can confirm that no payed developer license is needed for the instructions.

@tekezo Neo2 is a popular keymap in Germany and having it supported will benefit karabiner-elements popularity. Could you offer your opinions on upstreaming Jan's changes into the master branch?

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 26, 2017

@jgosmann Your build instructions and installation information are correct and working. Thanks again for putting this together.

Just to verify: Did you end up clicking the “Create” button next to “Mac development”? Also, it just occurred to me that the other buttons might have been greyed out because the corresponding signing keys were already generated.

@jgosmann Your build instructions and installation information are correct and working. Thanks again for putting this together.

Just to verify: Did you end up clicking the “Create” button next to “Mac development”? Also, it just occurred to me that the other buttons might have been greyed out because the corresponding signing keys were already generated.

@tjanson

This comment has been minimized.

Show comment
Hide comment
@tjanson

tjanson Jan 26, 2017

I can confirm that it builds fine using a key created with ”Mac Development” (the other option was greyed out for me too — possibly due to this, but it doesn’t seem important).

After trying it for a few minutes, the only odd thing I notice is Home/Pos 1 & End (i.e., Mod4+U/O (Neo) = Mod4+A/G (Qwertz labels)). In my El Capitan / Karabiner setup, they move the cursor to the beginning/end of line (when in a text field), while now they scroll to the top/bottom. (Maybe that’s actually intended, but I’m definitely not used to it.)

(Also: re-adjust the key repeat settings to something sane like 250 / 50.)

Thank you very much @jgosmann! Maybe I’ll dare to update to Sierra after all. ;)

tjanson commented Jan 26, 2017

I can confirm that it builds fine using a key created with ”Mac Development” (the other option was greyed out for me too — possibly due to this, but it doesn’t seem important).

After trying it for a few minutes, the only odd thing I notice is Home/Pos 1 & End (i.e., Mod4+U/O (Neo) = Mod4+A/G (Qwertz labels)). In my El Capitan / Karabiner setup, they move the cursor to the beginning/end of line (when in a text field), while now they scroll to the top/bottom. (Maybe that’s actually intended, but I’m definitely not used to it.)

(Also: re-adjust the key repeat settings to something sane like 250 / 50.)

Thank you very much @jgosmann! Maybe I’ll dare to update to Sierra after all. ;)

@SirVer

This comment has been minimized.

Show comment
Hide comment
@SirVer

SirVer Jan 27, 2017

@jgosmann First issues I encountered:

  • CapsLock/Right Cmd + Qwerty-A used to jump to the beginning of the line, but now instead scrolls up.
  • CapsLock/Right Cmd + qwerty-asdf are the cursor keys. But adding shift to select text does not work, but did before.

SirVer commented Jan 27, 2017

@jgosmann First issues I encountered:

  • CapsLock/Right Cmd + Qwerty-A used to jump to the beginning of the line, but now instead scrolls up.
  • CapsLock/Right Cmd + qwerty-asdf are the cursor keys. But adding shift to select text does not work, but did before.

@jgosmann jgosmann referenced this issue in jgosmann/Karabiner-Elements-Neo Jan 27, 2017

Closed

Home/end key behaviour #1

@jgosmann

This comment has been minimized.

Show comment
Hide comment
@jgosmann

jgosmann Jan 27, 2017

I think it would be best to post such issues to the jgosmann/Karabiner-Elements-Neo issue tracker and discuss them there. I just noticed that the issues tab was deactivated, but I enabled it now. I also added the problems mentioned as jgosmann/Karabiner-Elements-Neo#1 and jgosmann/Karabiner-Elements-Neo#2. I will fix them as soon as I have time.

I think it would be best to post such issues to the jgosmann/Karabiner-Elements-Neo issue tracker and discuss them there. I just noticed that the issues tab was deactivated, but I enabled it now. I also added the problems mentioned as jgosmann/Karabiner-Elements-Neo#1 and jgosmann/Karabiner-Elements-Neo#2. I will fix them as soon as I have time.

@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Mar 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot commented Mar 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 4, 2018

@stale stale bot closed this Mar 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment