Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildpacks task should support platform API 0.4 #525

Closed
natalieparellano opened this issue Sep 29, 2020 · 8 comments
Closed

buildpacks task should support platform API 0.4 #525

natalieparellano opened this issue Sep 29, 2020 · 8 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@natalieparellano
Copy link
Contributor

Expected Behavior

Buildpacks task should support buildpacks platform API 0.4

Actual Behavior

It currently supports platform API 0.3

Additional Info

This may be as simple as changing this line (and the equivalent one in buildpacks-phases):

from 0.3 -> 0.4

We may wish to provide additional documentation around the changes that don't require the pipeline to be configured any differently, but might affect how users interact with the output: multi-call launcher, report.toml (including how to capture this if desired), removal of version from the BOM, error code interpretation. The Platform 0.4 milestone in buildpacks/spec has more detail about these changes.

@natalieparellano
Copy link
Contributor Author

natalieparellano commented Sep 29, 2020

https://kubernetes.io/docs/tasks/debug-application-cluster/determine-reason-pod-failure/#customizing-the-termination-message for capturing report.toml

Edit: on second thought, the lifecycle writes report.toml in /layers which is already a mounted volume, so probably we can just access it from the volume after the build.

@natalieparellano
Copy link
Contributor Author

Started looking into this today, a couple of notes:

  • the path for report.toml (-report) if not specified defaults to the working directory of the lifecycle which I thought was /layers, but I didn't see a report.toml there at the end of the build. Explicitly setting the path did produce a report. I am not sure where the report ends up in the default case.
  • I tried setting terminationMessagePath: /layers/report.toml but I don't see the contents of the report in the logs even though the report is there (I tested it by adding a step at the end of the build to cat the contents of the file). Does terminationMessagePath not get populated on a successful run? This test suggests that the message should be there, but probably I am missing something...
  • I think terminationMessagePath is probably the right way to get the report (assuming we can get it to work) as the layers volume mount is currently not configurable

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2020
@natalieparellano
Copy link
Contributor Author

/remove-lifecycle stale

I think this is something we still want to do. @jromero are you looking at it?

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@jromero
Copy link
Member

jromero commented Feb 26, 2021

Resolved by buildpacks/tekton-integration#16. To be released any day now. 😄

@jromero
Copy link
Member

jromero commented Mar 22, 2021

This is now done as part of our latest release of task/buildpacks.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2021
@natalieparellano
Copy link
Contributor Author

This is now done as part of our latest release of task/buildpacks.

I think this issue can be closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants