Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes catalog refresh tests and lint errors #225

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Fixes catalog refresh tests and lint errors #225

merged 1 commit into from
Mar 30, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Mar 29, 2021 •
edited
Loading

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2021
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@pratap0007
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@sm43
Copy link
Member Author

sm43 commented Mar 30, 2021

/retest

@pratap0007
Copy link
Contributor

/woof

@tekton-robot
Copy link

@pratap0007: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PuneetPunamiya
Copy link
Member

/lgtm
/meow

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pratap0007
Copy link
Contributor

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pratap0007, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pratap0007,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fixes catalog refresh tests and lint errors
ca17c83 
Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@sm43
Copy link
Member Author

sm43 commented Mar 30, 2021

/retest

4 similar comments
@sm43
Copy link
Member Author

sm43 commented Mar 30, 2021

/retest

@sm43
Copy link
Member Author

sm43 commented Mar 30, 2021

/retest

@sm43
Copy link
Member Author

sm43 commented Mar 30, 2021

/retest

@sm43
Copy link
Member Author

sm43 commented Mar 30, 2021

/retest

@pratap0007
Copy link
Contributor

/lgtm
/meow

@tekton-robot
Copy link

@pratap0007: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@tekton-robot tekton-robot merged commit 6345073 into tektoncd:main Mar 30, 2021
@sm43 sm43 deleted the fix-errors branch March 30, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@pratap0007 pratap0007

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sm43 @pratap0007 @tekton-robot @PuneetPunamiya @vdemeester