Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all used images configurable #610

Closed
Obirah opened this issue Feb 2, 2022 · 14 comments
Closed

Make all used images configurable #610

Obirah opened this issue Feb 2, 2022 · 14 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Obirah
Copy link

Obirah commented Feb 2, 2022

Feature request

Currently the tekton operator and all the components it deploys use images from gcr.io - of course, this should remain the sane default, however when using the operator in an enterprise environment one needs to change the images so that mirrors can be used.

Use case

In our corporate environment we use Artifactory in order to use remotes of the big image repositories like Docker Hub, gcr, quay and so on. As a workaround gcr.io can be accessed through a proxy, but it is highly encouraged by our security/compliance guidelines to use our remotes instead of directly accessing the repositories.

@Obirah Obirah added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 2, 2022
@nikhil-thomas
Copy link
Member

This is currently doable in operator by setting environment variables. We do this while creating operator releases which is made available on Red Hat OpenShift.

Currently we can override images by setting environment variables like this in the operator controller deployment.

I shall document this better.

@Obirah
Copy link
Author

Obirah commented Feb 10, 2022

Cool, thank you for the information, that eases some pain! :) However, mid- and long-term I think it would be cooler to be able to configure this through custom resources. In my opinion the ArgoCD operator is a good example on how to approach this topic.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2022
@Obirah
Copy link
Author

Obirah commented May 11, 2022

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2022
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2022
@Obirah
Copy link
Author

Obirah commented Aug 10, 2022

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2022
@vdemeester
Copy link
Member

@Obirah probably a naive question : would it work to use kustomize for this ? (aka replacing the set of image with an overlay or something)

@DarthBlair
Copy link

This is currently doable in operator by setting environment variables. We do this while creating operator releases which is made available on Red Hat OpenShift.

Currently we can override images by setting environment variables like this in the operator controller deployment.

I shall document this better.

Thanks!
At the moment we are unable to identify the env variable for changing the dashboard image. Does anyone have a hint or solution for that as well?

@Oded-B
Copy link

Oded-B commented Sep 19, 2022

This is currently doable in operator by setting environment variables. We do this while creating operator releases which is made available on Red Hat OpenShift.

Does the fact that those env vars are missing from the k8s bundle config means they wouldn't work with the k8s operator in its current form?

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2022
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 17, 2023
@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@willzhang
Copy link

willzhang commented Dec 4, 2023

It's impossible for offline install with helm chart with tekton v0.68.1, if we can do this it will be greate:

helm install tekton-operator
--set chains.image.url=xxx:v0.17.1
--set dashboard.image.url=xxx:v0.17.1
--set hub.image.url=xxx:v0.17.1
--set pipeline.image.url=xxx:v0.17.1
--set pipelines-as-code.image.url=xxx:v0.17.1
--set results.image.url=xxx:v0.17.1
--set triggers.image.url=xxx:v0.17.1

or support extra env

helm install tekton-operator
--set extraEnv.IMAGE_PIPELINES_PROXY=docker.io/xxx/xxx/tekton-operator-proxy-webhook:v0.60.0
--set extraEnv.IMAGE_JOB_PRUNER_TKN=docker.io/xxx/xxx/tekton-operator-pruner-tkn:v0.60.0
--set extraEnv.IMAGE_PIPELINES_TEKTON_PIPELINES_CONTROLLER=docker.io/xxx/xxx/tekton-controller:v0.37.2
--set extraEnv.IMAGE_PIPELINES_WEBHOOK=docker.io/xxx/xxx/tekton-webhook:v0.37.2
--set extraEnv.IMAGE_PIPELINES_ARG__ENTRYPOINT_IMAGE=docker.io/xxx/xxx/tekton-entrypoint:v0.37.2
--set extraEnv.IMAGE_PIPELINES_ARG__GIT_IMAGE=docker.io/xxx/xxx/tekton-git-init:v0.37.2
--set extraEnv.IMAGE_PIPELINES_ARG__IMAGEDIGEST_EXPORTER_IMAGE=docker.io/xxx/xxx/tekton-imagedigestexporter:v0.37.2
--set extraEnv.IMAGE_PIPELINES_ARG__KUBECONFIG_WRITER_IMAGE=docker.io/xxx/xxx/tekton-kubeconfigwriter:v0.37.2
--set extraEnv.IMAGE_PIPELINES_ARG__NOP_IMAGE=docker.io/xxx/xxx/tekton-nop:v0.37.2
--set extraEnv.IMAGE_TRIGGERS_TEKTON_TRIGGERS_CONTROLLER=docker.io/xxx/xxx/tekton-triggers-controller:v0.20.1
--set extraEnv.IMAGE_TRIGGERS_WEBHOOK=docker.io/xxx/xxx/tekton-triggers-webhook:v0.20.1
--set extraEnv.IMAGE_TRIGGERS_TEKTON_TRIGGERS_CORE_INTERCEPTORS=docker.io/xxx/xxx/tekton-triggers-interceptors:v0.20.1
--set extraEnv.IMAGE_TRIGGERS_ARG__EL_IMAGE=docker.io/xxx/xxx/tekton-triggers-eventlistenersink:v0.20.1

A previous issue:#908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
Status: Done
Development

No branches or pull requests

7 participants