Use dedicated release ServiceAccount in PAC release pipelines#3364
Merged
Conversation
The wait-for-chains task needs to list/get TaskRuns to check Tekton Chains signing status. The default SA lacks these RBAC permissions, causing wait-for-chains to return signed='error' and skipping the create-draft-release task. Use the 'release' SA provisioned in tektoncd/plumbing with the required RBAC permissions. /kind bug
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XS
Contributor
|
/lgtm |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use the dedicated
releaseServiceAccount (provisioned intektoncd/plumbing#3335)
in both
.tekton/release-patch.yamland.tekton/release.yaml.The
wait-for-chainstask needs to list/get TaskRuns to check TektonChains signing status. The
defaultSA lacks these RBAC permissions,causing
wait-for-chainsto returnsigned="error"and skipping thecreate-draft-releasetask.Depends on: tektoncd/plumbing#3335
/kind bug
Submitter Checklist
make test lintbefore submitting a PRRelease Notes