feat(tls): make central TLS opt-out by default#3416
Merged
Conversation
Change EnableCentralTLSConfig from an opt-in bool to an opt-out *bool so central TLS configuration is active by default on all OpenShift clusters (SRVKP-9615). SetDefaults now sets EnableCentralTLSConfig = true when the field is nil (e.g. existing CRs on upgrade). Users who need to manage TLS manually can set enableCentralTLSConfig: false to opt out. ResolveCentralTLSToEnvVars and GetPlatformData are updated to treat nil as enabled; only an explicit false suppresses TLS injection. Also add ssl_conf_command Groups X25519MLKEM768:X25519 to the nginx TLS directive builder for the console plugin. This enables the ML-KEM hybrid key exchange group required for PQC readiness whenever TLS 1.3 is in scope (which is always the case, since convertTLSVersionToNginx always includes TLSv1.3). Fixes the PQC TLS scan failure: PQC: ML-KEM not supported (no x25519mlkem768 or mlkem768) Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 4.6 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
jkhelil
changed the title
Member
Author
|
/retest |
Member
Author
|
/kind feature |
tekton-robot
added
the
kind/feature
Contributor
|
/lgtm |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anithapriyanatarajan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Make
EnableCentralTLSConfigopt-out (default: enabled)EnableCentralTLSConfigwas a plainbool(opt-in, defaultfalse), meaning everyOpenShift cluster had to explicitly set it to
truebefore any TLS profile injectionkicked in — defeating the point of a cluster-wide security policy.
This PR changes the field type to
*booland defaults it totrueviaSetDefaults:nil;SetDefaultssets
nil → trueon the next reconcile, so TLS injection is transparently enabled.enableCentralTLSConfig: falsein theirTektonConfigCR.ResolveCentralTLSToEnvVarsandGetPlatformDataare updated to treatnilasenabled; only an explicit
falsesuppresses injection.Submitter Checklist
make test lintbefore submitting a PRRelease Notes
Made with Cursor