From 2474aa6171f920fe5cdf7cf8630d701186f36f47 Mon Sep 17 00:00:00 2001 From: Chitrang Patel Date: Mon, 10 Jun 2024 14:56:58 -0400 Subject: [PATCH] Promote Larger Results via Sidecar Logs to Beta This PR promotes Larger Results via Sidecar Logs to Beta. All items as per Issue https://github.com/tektoncd/pipeline/issues/6133 have been completed. It was released in `v0.43` so has been in an alpha state for a while now. --- config/config-feature-flags.yaml | 3 +-- docs/additional-configs.md | 2 +- docs/tasks.md | 2 +- examples/v1/taskruns/{alpha => beta}/large-task-result.yaml | 0 test/e2e-tests-kind-prow-beta.env | 1 + test/featureflags.go | 1 + 6 files changed, 5 insertions(+), 4 deletions(-) rename examples/v1/taskruns/{alpha => beta}/large-task-result.yaml (100%) diff --git a/config/config-feature-flags.yaml b/config/config-feature-flags.yaml index 26a97d523b7..dcc52f95c7d 100644 --- a/config/config-feature-flags.yaml +++ b/config/config-feature-flags.yaml @@ -107,8 +107,7 @@ data: enforce-nonfalsifiability: "none" # Setting this flag will determine how Tekton pipelines will handle extracting results from the task. # Acceptable values are "termination-message" or "sidecar-logs". - # "sidecar-logs" is an experimental feature and thus should still be considered - # an alpha feature. + # "sidecar-logs" is now a beta feature. results-from: "termination-message" # Setting this flag will determine the upper limit of each task result # This flag is optional and only associated with the previous flag, results-from diff --git a/docs/additional-configs.md b/docs/additional-configs.md index 417843a7105..3e517eec5fa 100644 --- a/docs/additional-configs.md +++ b/docs/additional-configs.md @@ -378,7 +378,6 @@ Features currently in "alpha" are: | [Step and Sidecar Overrides](./taskruns.md#overriding-task-steps-and-sidecars) | [TEP-0094](https://github.com/tektoncd/community/blob/main/teps/0094-specifying-resource-requirements-at-runtime.md) | [v0.34.0](https://github.com/tektoncd/pipeline/releases/tag/v0.34.0) | | | [StdoutConfig and StderrConfig](./tasks#redirecting-step-output-streams-with-stdoutConfig-and-stderrConfig) | [TEP-0011](https://github.com/tektoncd/community/blob/main/teps/0011-redirecting-step-output-streams.md) | [v0.38.0](https://github.com/tektoncd/pipeline/releases/tag/v0.38.0) | | | [Trusted Resources](./trusted-resources.md) | [TEP-0091](https://github.com/tektoncd/community/blob/main/teps/0091-trusted-resources.md) | [v0.49.0](https://github.com/tektoncd/pipeline/releases/tag/v0.49.0) | `trusted-resources-verification-no-match-policy` | -| [Larger Results via Sidecar Logs](#enabling-larger-results-using-sidecar-logs) | [TEP-0127](https://github.com/tektoncd/community/blob/main/teps/0127-larger-results-via-sidecar-logs.md) | [v0.43.0](https://github.com/tektoncd/pipeline/releases/tag/v0.43.0) | `results-from` | | [Configure Default Resolver](./resolution.md#configuring-built-in-resolvers) | [TEP-0133](https://github.com/tektoncd/community/blob/main/teps/0133-configure-default-resolver.md) | [v0.46.0](https://github.com/tektoncd/pipeline/releases/tag/v0.46.0) | | | [Coschedule](./affinityassistants.md) | [TEP-0135](https://github.com/tektoncd/community/blob/main/teps/0135-coscheduling-pipelinerun-pods.md) | [v0.51.0](https://github.com/tektoncd/pipeline/releases/tag/v0.51.0) | `coschedule` | | [keep pod on cancel](./taskruns.md#cancelling-a-taskrun) | N/A | [v0.52.0](https://github.com/tektoncd/pipeline/releases/tag/v0.52.0) | `keep-pod-on-cancel` | @@ -403,6 +402,7 @@ Features currently in "beta" are: | [Matrix](./matrix.md) | [TEP-0090](https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md) | [v0.38.0](https://github.com/tektoncd/pipeline/releases/tag/v0.38.0) | [v0.53.0](https://github.com/tektoncd/pipeline/releases/tag/v0.53.0) | | | [Task-level Resource Requirements](compute-resources.md#task-level-compute-resources-configuration) | [TEP-0104](https://github.com/tektoncd/community/blob/main/teps/0104-tasklevel-resource-requirements.md) | [v0.39.0](https://github.com/tektoncd/pipeline/releases/tag/v0.39.0) | [v0.53.0](https://github.com/tektoncd/pipeline/releases/tag/v0.53.0) | | | [Reusable Steps via StepActions](./stepactions.md) | [TEP-0142](https://github.com/tektoncd/community/blob/main/teps/0142-enable-step-reusability.md) | [v0.54.0](https://github.com/tektoncd/pipeline/releases/tag/v0.54.0) | `enable-step-actions` | +| [Larger Results via Sidecar Logs](#enabling-larger-results-using-sidecar-logs) | [TEP-0127](https://github.com/tektoncd/community/blob/main/teps/0127-larger-results-via-sidecar-logs.md) | [v0.43.0](https://github.com/tektoncd/pipeline/releases/tag/v0.43.0) | [v0.61.0](https://github.com/tektoncd/pipeline/releases/tag/v0.61.0) | `results-from` | ## Enabling larger results using sidecar logs diff --git a/docs/tasks.md b/docs/tasks.md index 0529e5ff8ee..852f324cc52 100644 --- a/docs/tasks.md +++ b/docs/tasks.md @@ -1017,7 +1017,7 @@ As a general rule-of-thumb, if a result needs to be larger than a kilobyte, you #### Larger `Results` using sidecar logs -This is an alpha feature which is guarded behind its own feature flag. The `results-from` feature flag must be set to +This is a beta feature which is guarded behind its own feature flag. The `results-from` feature flag must be set to [`"sidecar-logs"`](./install.md#enabling-larger-results-using-sidecar-logs) to enable larger results using sidecar logs. Instead of using termination messages to store results, the taskrun controller injects a sidecar container which monitors diff --git a/examples/v1/taskruns/alpha/large-task-result.yaml b/examples/v1/taskruns/beta/large-task-result.yaml similarity index 100% rename from examples/v1/taskruns/alpha/large-task-result.yaml rename to examples/v1/taskruns/beta/large-task-result.yaml diff --git a/test/e2e-tests-kind-prow-beta.env b/test/e2e-tests-kind-prow-beta.env index 516f4675938..acf7b599ce8 100644 --- a/test/e2e-tests-kind-prow-beta.env +++ b/test/e2e-tests-kind-prow-beta.env @@ -2,6 +2,7 @@ SKIP_INITIALIZE=true PIPELINE_FEATURE_GATE=beta EMBEDDED_STATUS_GATE=minimal RUN_YAML_TESTS=true +RESULTS_FROM=sidecar-logs ENABLE_STEP_ACTIONS=true KO_DOCKER_REPO=registry.local:5000 E2E_GO_TEST_TIMEOUT=40m diff --git a/test/featureflags.go b/test/featureflags.go index 0f5cd810ff0..823d19b998f 100644 --- a/test/featureflags.go +++ b/test/featureflags.go @@ -124,6 +124,7 @@ func getFeatureFlagsBaseOnAPIFlag(t *testing.T) *config.FeatureFlags { t.Fatalf("error creating alpha feature flags configmap: %v", err) } betaFeatureFlags, err := config.NewFeatureFlagsFromMap(map[string]string{ + "results-from": "sidecar-logs", "enable-api-fields": "beta", "enable-step-actions": "true", })