Remove deprecated fields from PipelineResourceResult 🍠 #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
vdemeester
force-pushed
the
remove-fields-pipelineresourceresult
branch
from
d8ea9c3
to
1fdf0dd
Compare
ghost
approved these changes
Feb 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/lgtm |
|
/test pull-tekton-pipeline-integration-tests |
uh oh it's like boskos knows im build cop |
/test pull-tekton-pipeline-integration-tests |
|
phew it's just flakey.... "Just" 😅 |
|
/test pull-tekton-pipeline-integration-tests two flakes in a row 🤔 😓 |
|
/retest |
1 similar comment
|
/retest |
The `Name` and `Digest` field have been deprecated in a previous release. This removes the fields from the struct. See tektoncd#1392 for the inital issue. It also reduce code duplication by aliasing some types between v1alpha1 and v1alpha2. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
remove-fields-pipelineresourceresult
branch
from
1fdf0dd
to
9668bb2
Compare
|
/lgtm |
|
According to the review notes, this must be approved by 50% of the owners, so here's my |
|
/test pull-tekton-pipeline-integration-tests |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
NameandDigestfield have been deprecated in a previousrelease. This removes the fields from the struct. See
#1392 for the inital issue.
It also reduce code duplication by aliasing some types between
v1alpha1 and v1alpha2.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/cc @bobcatfish @othomann @dlorenc @sbwsg
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes