Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc about migrating from v1alpha1 to v1beta1 #2231

Merged
merged 1 commit into from Apr 7, 2020
Merged

Doc about migrating from v1alpha1 to v1beta1 #2231

merged 1 commit into from Apr 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 14, 2020 •
edited by ghost
Loading

Changes

We don't currently have any documentation that's specific to migration from v1alpha1 to v1beta1.

This commit introduces a doc describing how to migrate. It details changes in the format of inputs/outputs as well as documenting suggested alternatives for some PipelineResources.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

A document has been added that describes the changes needed when migrating from v1alpha1 to v1beta1.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2020
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Mar 14, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 14, 2020
vdemeester
vdemeester reviewed Mar 16, 2020
View reviewed changes
docs/migrating-v1alpha1-to-v1beta1.md Outdated
Comment on lines 167 to 169
### Image Resource

WIP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is trickier than the other. We can provide a task for it, but most likely it's way more efficient to have a step for the image builder that support this, like here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I see. So instead of an explicit Task called "ImageOutput", this is really just replaced with a digest result / params or similar. And any task that generates an image could receive / output those. Makes sense.

@vdemeester
Copy link
Member

/kind documentation
/kind beta-blocking

@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/beta-blocking Categorizes issue or PR as related to the beta api labels Mar 17, 2020
Doc about migrating from v1alpha1 to v1beta1
ce9f179 
We don't currently have any documentation that's specific to migration
from v1alpha1 to v1beta1.

This commit introduces a doc describing how to migrate. It details
changes in the format of inputs/outputs as well as documenting
suggested alternatives for some PipelineResources.
@ghost ghost changed the title WIP Draft of doc about migrating from v1alpha1 to v1beta1 Draft of doc about migrating from v1alpha1 to v1beta1 Apr 6, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2020
@ghost ghost removed the kind/beta-blocking Categorizes issue or PR as related to the beta api label Apr 6, 2020
vdemeester
vdemeester approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@ghost ghost changed the title Draft of doc about migrating from v1alpha1 to v1beta1 Doc about migrating from v1alpha1 to v1beta1 Apr 7, 2020
@ghost
Copy link
Author

ghost commented Apr 7, 2020

@googlebot rescan

@tekton-robot tekton-robot merged commit 9a61678 into tektoncd:master Apr 7, 2020
@ghost ghost added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Apr 8, 2020
@bobcatfish
Copy link
Collaborator

@sbwsg could we add a link to this somewhere, maybe from the main README? maybe even on the website?

@ghost
Copy link
Author

ghost commented Apr 8, 2020

Opened a PR to add a link to the readme: #2351

@ghost ghost removed the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer Awaiting requested review from abayer

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vdemeester @tekton-robot @bobcatfish @googlebot