Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate certain Pipeline examples into their own namespace #217

Closed
ghost opened this issue Feb 6, 2020 · 10 comments
Closed

Isolate certain Pipeline examples into their own namespace #217

ghost opened this issue Feb 6, 2020 · 10 comments
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ghost
Copy link

ghost commented Feb 6, 2020

Desirable Behavior

A couple of the examples we have in Pipeline need to run in their own namespace in order to test them without leaking some state into other running examples. Specifically the LimitRangeName examples which currently have to live under a no-ci directory so they don't run. If run in the same namespace as other examples they will cause some minor explosions that prevent the PR from passing checks.

So it'd be desirable for the examples to either choose their own namespace name (using whatever default that is used currently if they don't specify one) OR we could run each example in its own tiny namespace that gets torn down after it finishes.

@ghost
Copy link
Author

ghost commented Feb 6, 2020

I'm actually not totally sure if this belongs in Plumbing or Pipelines. Sorry if this is the wrong place :S

@ghost
Copy link
Author

ghost commented Feb 6, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 6, 2020
@danielhelfand
Copy link
Member

Would there be anything that prevents examples from creating a namespace and then just specifying that the resources should be created in the namespace that is part of the example?

@ghost
Copy link
Author

ghost commented Feb 18, 2020

interesting. So they'd include a namespace document as part of their yaml? The only issue I could see there is collisions if multiple test runs are going at once. Does that happen? I'm not clear.

@danielhelfand
Copy link
Member

interesting. So they'd include a namespace document as part of their yaml?

Yes, so add in a namespace to the YAML and have the resources be created in the namespace. It could get a bit unorganized as far as maintaining, but perhaps it could be reserved for specific cases.

The only issue I could see there is collisions if multiple test runs are going at once. Does that happen? I'm not clear.

It's a good question. I'm not familiar with exactly what is done for integration testing as far as infrastructure. What is provided for each pull request when integration tests are run?

@ghost
Copy link
Author

ghost commented Feb 20, 2020

What is provided for each pull request when integration tests are run?

OK I think I was way off base with my last comment. It looks like we spin up a completely fresh cluster for each integration test run (or, rather, Boskos does this). So using a namespace won't collide I don't think. 👍

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2020
@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants