-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate certain Pipeline examples into their own namespace #217
Comments
I'm actually not totally sure if this belongs in Plumbing or Pipelines. Sorry if this is the wrong place :S |
/kind feature |
Would there be anything that prevents examples from creating a namespace and then just specifying that the resources should be created in the namespace that is part of the example? |
interesting. So they'd include a namespace document as part of their yaml? The only issue I could see there is collisions if multiple test runs are going at once. Does that happen? I'm not clear. |
Yes, so add in a namespace to the YAML and have the resources be created in the namespace. It could get a bit unorganized as far as maintaining, but perhaps it could be reserved for specific cases.
It's a good question. I'm not familiar with exactly what is done for integration testing as far as infrastructure. What is provided for each pull request when integration tests are run? |
OK I think I was way off base with my last comment. It looks like we spin up a completely fresh cluster for each integration test run (or, rather, Boskos does this). So using a namespace won't collide I don't think. 👍 |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Desirable Behavior
A couple of the examples we have in Pipeline need to run in their own namespace in order to test them without leaking some state into other running examples. Specifically the LimitRangeName examples which currently have to live under a
no-ci
directory so they don't run. If run in the same namespace as other examples they will cause some minor explosions that prevent the PR from passing checks.So it'd be desirable for the examples to either choose their own namespace name (using whatever default that is used currently if they don't specify one) OR we could run each example in its own tiny namespace that gets torn down after it finishes.
The text was updated successfully, but these errors were encountered: