New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_params_lxc: storage parameter doesn't support size #32

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@GamerSource
Copy link

GamerSource commented Apr 12, 2016

The storage parameter is for the storage only, nothing more.
Use the rootfs parameter to correctly sent the the disk size
and the storage to the PVE API2.

Addresses:
#26 (comment)

create_params_lxc: storage parameter doesn't support size
The storage parameter is for the storage only, nothing more.
Use the rootfs parameter to correctly give the PVE API the disk size and the storage.

Addresses:
#26 (comment)
@lehn-etracker

This comment has been minimized.

Copy link

lehn-etracker commented Aug 12, 2016

This patch helped me a lot, while trying to use test-kitchen + kitchen-vagrant + vagrant-proxmox. It would be nice to see this patch applied shortly.

GastonGonzalez pushed a commit to GastonGonzalez/vagrant-proxmox that referenced this pull request Dec 26, 2016

@tadman

This comment has been minimized.

Copy link

tadman commented Jul 13, 2017

I've also discovered that the storage parameter is not the right thing to use for this, that rootfs is the correct argument. This needs to be updated to work with recent versions of Proxmox for LXC containers.

@lehn-etracker

This comment has been minimized.

Copy link

lehn-etracker commented Jul 14, 2017

@tadman try my fork please https://github.com/lehn-etracker/vagrant-proxmox we use it only with LXC and Proxmox 4.4

@GamerSource

This comment has been minimized.

Copy link

GamerSource commented Jul 17, 2017

@tadman yes, my pull request would exactly do that, sadly @telcat seems to be inactive or have no interest in maintaining this anymore.
@lehn-etracker fork should give you what you want :)

@tadman

This comment has been minimized.

Copy link

tadman commented Jul 17, 2017

If the Telcat version is defunct then this is a candidate for replacement. This is the version referenced in the Vagrant documentation, so if the @lehn-etracker version is more up to date it'd be nice if that one was also published as a gem and linked accordingly if the license allows for such things, which it should since this is under the MIT license.

I wasn't able to get things working with this version yet, I ran into other issues, but I'll keep trying to get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment