REMOVE ngsiv1 ops aligned with CB 4.0.0 #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
commented
Jun 12, 2024
| * @param {Object} logger Instance of logops.Logger | ||
| * @param {String} body Raw string payload. | ||
| */ | ||
| function inspectBodyXML(logger, body, callback) { |
There was a problem hiding this comment.
XML in Orion was removed in version 1.0.0 (more than 8 years ago. It's a bit surprising this has survived so long in PEP code :)
NTC (informative)
There was a problem hiding this comment.
Keypass still uses XML, but not usually is exposed and then no needs a pep.
There was a problem hiding this comment.
You are right. I was referring to XML in the NGSI API. The rests of XML support in PEP (Keypass, etc.) has been preserved.
fgalan
force-pushed
the
remove/ngsiv1-ops
branch
from
ea39101
to
eea9400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #523