Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format and lint Markdown text files #389

Merged
merged 4 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@jason-fox
Copy link
Contributor

jason-fox commented Mar 6, 2019

Similar to #377 - This change to package.json introduces markdown textlint linting and markdown formatting using prettier.

  • The text is checked for spelling errors, bad grammar and dead links (on CI)
  • The markdown is nicely formatted. (on Husky commit)
  • The code snippets within the markdown are formatted (on Husky commit)
@@ -0,0 +1,7819 @@
{

This comment has been minimized.

Copy link
@fgalan

fgalan Mar 6, 2019

Member

Please remove package-lock.json from the PR.

This comment has been minimized.

Copy link
@jason-fox

jason-fox Mar 6, 2019

Author Contributor

Fixed d048ba6

"prettier": "~1.14.2",
"proxyquire": "2.1.0",
"remark-cli": "~6.0.1",
"remark-preset-lint-recommended": "^3.0.2",

This comment has been minimized.

Copy link
@fgalan

fgalan Mar 6, 2019

Member

^ -> ~ in dependencies.

This comment has been minimized.

Copy link
@jason-fox

jason-fox Mar 6, 2019

Author Contributor

Fixed d048ba6 and 604cc2f

jason-fox added some commits Mar 6, 2019

@fgalan

fgalan approved these changes Mar 8, 2019

Copy link
Member

fgalan left a comment

LGTM. Thanks!

Passing the ball to @dcalvoalonso for additional LGTM before merging.

@dcalvoalonso

This comment has been minimized.

Copy link
Contributor

dcalvoalonso commented Mar 13, 2019

LGTM

@fgalan fgalan merged commit 4e50070 into telefonicaid:master Mar 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.817%
Details

@jason-fox jason-fox deleted the jason-fox:feature/text-lint branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.