New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): Fix for importing and handling project-stylesheet if only tokens are used. #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayaKrishnaNamburu
added
the
style flavours
All issues and pull requests that are relates to styles. (Adding a style plugins, making a change)
label
Jan 8, 2021
Codecov Report
@@ Coverage Diff @@
## development #530 +/- ##
===============================================
- Coverage 76.27% 75.90% -0.38%
===============================================
Files 156 156
Lines 5698 5710 +12
Branches 1208 1227 +19
===============================================
- Hits 4346 4334 -12
- Misses 1291 1309 +18
- Partials 61 67 +6
Continue to review full report at Codecov.
|
JayaKrishnaNamburu
changed the title
fix(styles): importing project-stylesheet if only tokens are used
fix(styles): Fix for importing and handling project-stylesheet if only tokens are used. We don't need to import style-sheet in every single component when there no re-usable styles
Jan 10, 2021
JayaKrishnaNamburu
changed the title
fix(styles): Fix for importing and handling project-stylesheet if only tokens are used. We don't need to import style-sheet in every single component when there no re-usable styles
fix(styles): Fix for importing and handling project-stylesheet if only tokens are used.
Jan 10, 2021
Utwo
previously approved these changes
Jan 11, 2021
👍 |
JayaKrishnaNamburu
force-pushed
the
fix/importing-stylesheet
branch
from
January 11, 2021 10:51
788971c
to
115adf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
style flavours
All issues and pull requests that are relates to styles. (Adding a style plugins, making a change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
tokens
andProject StyleSheet
are tightly coupled. Like tokens forcss
andcss-modules
are basically css-variables. Which works only when imported. But if a project is not usingproject-style-sheet
at all. Then the tokens are not imported. So, need some extra checks and ways. So, if the project-style-sheet is not used. Then tokens are imported directly in the router of the project. Which is a entry point.fixes #529
TODO