Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection not closing since release 0.100 #1052

Closed
benfdking opened this issue Jun 18, 2019 · 2 comments

Comments

2 participants
@benfdking
Copy link

commented Jun 18, 2019

Since version 0.100, the connection does not stop after running go tests in telepresence with

telepresence --run go test -tags=integrationtests ./integrationtests/...

It can be shut off with CTRL-C but is no longer as useful for our CI solution which used telepresence to just run some code against our cluster with go tests.

kubectl info

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-07T09:55:27Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.6-gke.6", GitCommit:"fcbc1d20b6bca1936c0317743055ac75aef608ce", GitTreeState:"clean", BuildDate:"2019-05-23T11:42:40Z", GoVersion:"go1.11.5b4", Compiler:"gc", Platform:"linux/amd64"}

@benfdking benfdking changed the title Connection Not closing since Connection not closing since release 0.100 Jun 18, 2019

@ark3

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

Thank you for the issue. Can you please suggest how I could replicate this?

@ark3

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

Blargh. Never mind. Again, thank you for the issue.

  • Figure out why our large battery of tests doesn't catch this
  • Fix the tests or add a test that catches this
  • Commit the fix (see below)
diff --git a/telepresence/runner/runner.py b/telepresence/runner/runner.py
index ac1100a..955a0ee 100644
--- a/telepresence/runner/runner.py
+++ b/telepresence/runner/runner.py
@@ -680,7 +680,7 @@ class Runner(object):
         self.write("Everything launched. Waiting to exit...")
         main_code = None
         span = self.span()
-        Thread(target=wait_for_process, args=(main_process, ))
+        Thread(target=wait_for_process, args=(main_process, )).start()
         while not self.quitting:
             sleep(0.1)
         span.end()

@ark3 ark3 added this to To do in Tel Tracker via automation Jun 18, 2019

@ark3 ark3 added the bug label Jun 18, 2019

@ark3 ark3 self-assigned this Jun 18, 2019

@ark3 ark3 moved this from To do to In progress in Tel Tracker Jun 19, 2019

@ark3 ark3 closed this in 9c87f30 Jun 19, 2019

Tel Tracker automation moved this from In progress to Done Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.