New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using --swap-deployment please auto expose ports that the deployment expects exposed #185

Closed
plombardi89 opened this Issue Jun 21, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@plombardi89
Contributor

plombardi89 commented Jun 21, 2017

No description provided.

@rhs

This comment has been minimized.

Contributor

rhs commented Jul 17, 2017

I ran into this as well. In my case the deployment doesn't actually specify any ports. They are only specified in my Dockerfile, however I think it would be relatively straightforward, and quite convenient, to infer a port to expose based on the service associated with the deployment.

@itamarst

This comment has been minimized.

Contributor

itamarst commented Jul 17, 2017

If no --expose is specified and no ports are detected, print out warning. Also should always print exposed ports, for security reasons. Finally, need to support case where --expose overrides auto-expose (specifically, we want to listen on different local port.)

And maybe there should also be a --no-auto-expose? Maybe if someone asks for it.

@itamarst itamarst added this to Next in Telepresence Jul 17, 2017

@itamarst itamarst moved this from Next to In progress in Telepresence Jul 18, 2017

itamarst added a commit that referenced this issue Jul 18, 2017

Merge pull request #229 from datawire/auto-expose-ports
Automatically expose ports when using --swap-deployment.

Fixes #185.

@itamarst itamarst removed this from In progress in Telepresence Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment