New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests under Docker on master #214

Closed
itamarst opened this Issue Jul 3, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@itamarst
Contributor

itamarst commented Jul 3, 2017

The problem: we use local environment variables as basis for env variables we set for subprocesses, which makes sense... but also for Docker container passed in with --docker-run, which doesn't make sense. Moreover, on master in Travis there is env variable with space in value, which breaks Docker seems like. Perhaps we just need quoting for that, but also we shouldn't use local env variables for --docker-run.

@itamarst itamarst added the bug label Jul 3, 2017

@itamarst itamarst closed this in #215 Jul 3, 2017

itamarst added a commit that referenced this issue Jul 3, 2017

Merge pull request #215 from datawire/docker-wrong-env
Don't use local env variables with --docker-run.

Fixes #214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment