New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--swap-deployment broken somehow in 0.62 #253

Closed
itamarst opened this Issue Jul 31, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@itamarst
Contributor

itamarst commented Jul 31, 2017

I'm following http://www.telepresence.io/tutorials/kubernetes.html basically.

Instead of swapping out the container, a second container is added, so there's both the original datawire-hello-world container and a second telepresence container in the resulting swapped-in Deployment. Doing --swap-deployment hello-world:hello-world, i.e. explicitly specifying the container to swap out, does work.

This suggests the logic for choosing first container when there is no container specified has regressed somehow, so need bug fix and test.

@itamarst itamarst added the bug label Jul 31, 2017

@itamarst itamarst added this to Next in Telepresence Jul 31, 2017

@itamarst

This comment has been minimized.

Contributor

itamarst commented Jul 31, 2017

The problem is that we assign a new name for the container if none is specified, and then kubectl apply -f does a merge where it adds the new container but doesn't delete old one.

itamarst added a commit that referenced this issue Jul 31, 2017

Merge pull request #254 from datawire/swap-deployment-problems
Unbreak --swap-deployment.

Fixes #253.

@itamarst itamarst removed this from Next in Telepresence Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment