Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need earlier sudo with clear/better prompt #262

Closed
ark3 opened this issue Aug 1, 2017 · 6 comments

Comments

3 participants
@ark3
Copy link
Contributor

commented Aug 1, 2017

If a sudo will be required, it should happen as early as possible. Rather than producing a bare password prompt, the prompt should be something very clear, like "sudo for Telepresence."

  • sudo as early as possible
  • Clear/explicit prompt (#720)

@ark3 ark3 self-assigned this Aug 1, 2017

@ark3 ark3 added the enhancement label Aug 30, 2017

@ark3

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2017

  • SUDO_FOR_DOCKER
  • MAC_LOOPBACK_IP
  • sshfs (only with Docker?)
  • sshuttle (vpn_tcp)

@ark3 ark3 added this to To Do in Container UX via automation Dec 12, 2017

@ark3 ark3 removed their assignment Dec 12, 2017

@ark3

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2018

If a password is required, we should make it clear that Telepresence has initiated the sudo command and explain why. One approach would be to set/override the environment variable SUDO_PROMPT with that information. However, I'd rather not make the user's sudo workflow surprising or confusing.

To avoid messing with SUDO_PROMPT, use something like sudo -n true to test whether privileged execution will require a password. This command will succeed if no password is required (either because it's never required, or because the user typed it recently enough). Otherwise, the command will fail. Upon failure, spew some explanatory text ("Telepresence requires your password for sudo to run Docker/sshfs/whatever") and then prompt with something like sudo -v.

This latter approach won't help if the OS configuration requires a password for every sudo command. Let's hope that is an uncommon configuration.

@plombardi89 plombardi89 added this to Features in Roadmap Feb 21, 2018

@rhs rhs added this to Enhancement in Buckets Mar 8, 2018

@ark3 ark3 added this to Output in Blobs Apr 9, 2018

@ddehghan

This comment has been minimized.

Copy link

commented Apr 23, 2018

Yeah. this is pretty scary to ask for a password without any context and what it needs it for. also it is not clear what password it needs. local machine or remote machine, kubernetes, docker root password etc.

@ark3 ark3 referenced this issue Aug 1, 2018

Merged

Testable various #720

ark3 added a commit that referenced this issue Aug 1, 2018

Merge pull request #720 from telepresenceio/testable-require-sudo
Make various remaining items testable.
Adds an explicit sudo warning to partly address #262.
Addresses the isatty item from #572.
Fixes #278.
Fixes #306.
In service of #628.
@ark3

This comment has been minimized.

Copy link
Contributor Author

commented Dec 4, 2018

I believe this was completed as a side effect of #732.

@ark3 ark3 closed this Dec 4, 2018

Roadmap automation moved this from Features to Completed Dec 4, 2018

@Imunhatep

This comment has been minimized.

Copy link

commented Apr 17, 2019

Not sure what was fixed.. but sudo pass promt still does not explain what for it asks for root:

T: Invoking sudo. Please enter your sudo password.

@ark3

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

Agreed. Let’s add a link to appropriate docs at that prompt.

@ark3 ark3 reopened this Apr 17, 2019

@ark3 ark3 added documentation and removed enhancement labels Apr 17, 2019

@ark3 ark3 added this to To do in Tel Tracker via automation Apr 17, 2019

@ark3 ark3 moved this from To do to In progress in Tel Tracker Apr 17, 2019

@ark3 ark3 closed this in f34665c Apr 17, 2019

Tel Tracker automation moved this from In progress to Done Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.