New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize build-linux.sh and .travis.yaml into a single widely usable (cloud) testing tool #374

Closed
exarkun opened this Issue Dec 14, 2017 · 4 comments

Comments

Projects
3 participants
@exarkun
Contributor

exarkun commented Dec 14, 2017

build-linux.sh is the de facto testing command during development.

.travis.yaml contains the testing steps used for testing during continuous integration.

Rather than having two definitions of what it means to run the test suite, there should be one. It should be usable by developers (who have access to a Kubernetes cluster; perhaps only the telepresence-testing GKE cluster to start) and by CI.

Its use should be documented to ease the path to becoming a telepresence developer.

@exarkun exarkun self-assigned this Dec 14, 2017

@exarkun exarkun added this to To Do in Container UX via automation Dec 14, 2017

@richarddli

This comment has been minimized.

Contributor

richarddli commented Dec 14, 2017

Originally everything was in .travis.yaml. I wanted to refactor things out of that file into shell scripts so it would be easier to do local builds. In particular, Mac OS X builds on Travis get really slow in the afternoon EST. I didn't finish this work, though.

@exarkun

This comment has been minimized.

Contributor

exarkun commented Dec 14, 2017

Is build-linux.sh the result of this refactoring? Or is it somewhere else (and is it worth using as the basis for this work)?

@richarddli

This comment has been minimized.

Contributor

richarddli commented Dec 14, 2017

I did the refactoring and cleanup in build-macosx.sh for the most part, with various fixes to the other packaging machinery as I went along. @ark3 started expanding on that work with build-linux.sh. So I think these two are the right places to start.

@ark3

This comment has been minimized.

Contributor

ark3 commented Dec 14, 2017

Yes, what @richarddli said is correct.

Related, but separate, it would be nice to be able to release outside of Travis too.

@ark3 ark3 moved this from To Do to In Progress in Container UX Dec 14, 2017

exarkun added a commit that referenced this issue Dec 22, 2017

Merge pull request #383 from datawire/374.unify-test-runners
Some generalization of build-linux.sh to make it usable by more folks.

Refs #374

@ark3 ark3 closed this in #385 Jan 11, 2018

Container UX automation moved this from In Progress to Done Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment