New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telepresence logfile has unstamped output via Runner.get_output(...) #390

Closed
ark3 opened this Issue Dec 28, 2017 · 0 comments

Comments

1 participant
@ark3
Contributor

ark3 commented Dec 28, 2017

Unstamped output leaks into the file via Runner.get_output(...) in runner.py. For example, this is apparent (and annoying) in the hellotelepresence DNS wait loop.

  16.6 TL | [39] Capturing: (['python3', '-c', "import socket; socket.gethostbyname('hellotelepresence6')"],)...
Traceback (most recent call last):
  File "<string>", line 1, in <module>
socket.gaierror: [Errno 8] nodename nor servname provided, or not known
  16.8 TL | [40] Capturing: (['python3', '-c', "import socket; socket.gethostbyname('hellotelepresence7')"],)...
Traceback (most recent call last):
  File "<string>", line 1, in <module>
socket.gaierror: [Errno 8] nodename nor servname provided, or not known

@ark3 ark3 added the bug label Dec 28, 2017

@plombardi89 plombardi89 added this to Bugs in Roadmap Feb 20, 2018

@rhs rhs added this to Bug in Buckets Mar 8, 2018

@ark3 ark3 self-assigned this Mar 28, 2018

@ark3 ark3 referenced this issue Apr 5, 2018

Merged

[WIP] Logging fixes #564

@ark3 ark3 closed this in #564 Apr 5, 2018

Roadmap automation moved this from Bugs to Completed Apr 5, 2018

ark3 added a commit that referenced this issue Apr 5, 2018

Merge pull request #564 from datawire/logging-fixes
Capture output using threads instead of additional processes
Fixes #390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment