New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telepresence should let the user optionally set TELEPRESENCE_ROOT #454

Closed
ark3 opened this Issue Feb 13, 2018 · 2 comments

Comments

1 participant
@ark3
Contributor

ark3 commented Feb 13, 2018

When using docker run a user has the opportunity to set up the application container's filesystem as desired using the --volume (-v) option. The same is true with Telepresence's container method, though currently this is limited to mounts from the local filesystem. Telepresence mounts the remote pod's filesystem under a randomly-generated path that is unavailable to the user until the docker run command has already launched. As such, the application must look for Kubernetes filesystem resources under the path $TELEPRESENCE_ROOT, which will be empty or not set when not running under Telepresence.

Letting the user override the randomly-generated path with a known path would allow some cases to avoid handling $TELEPRESENCE_ROOT entirely. For example, some applications need Kubernetes secrets but no other remote filesystem resources. This feature would allow mapping secrets into the normal place on the filesystem (/var/run/secrets) directly as part of the Telepresence invocation via --docker-run -v /known/root/path/var/run/secrets:/var/run/secrets.

@ark3 ark3 added the enhancement label Feb 13, 2018

@plombardi89 plombardi89 added this to Features in Roadmap Feb 21, 2018

@richarddli richarddli added this to Better UX in T Roadmap (v2) Feb 21, 2018

@rhs rhs added this to Enhancement in Buckets Mar 8, 2018

@ark3

This comment has been minimized.

Contributor

ark3 commented Apr 6, 2018

How about this?

  • --mount=True for the current behavior (path randomly-generated)
  • --mount=/known/path to specify a path
  • --mount=False to turn off filesystem mounting entirely, like #412.

@ark3 ark3 added this to To Do in Container UX via automation Apr 6, 2018

@ark3 ark3 self-assigned this Apr 10, 2018

@ark3

This comment has been minimized.

Contributor

ark3 commented Apr 23, 2018

$ telepresence --mount=/tmp/known --docker-run --rm -it -v=/tmp/known/var/run/secrets:/var/run/secrets lachlanevenson/k8s-kubectl version --short
Volumes are rooted at $TELEPRESENCE_ROOT. See https://telepresence.io/howto/volumes.html for details.

Client Version: v1.10.1
Server Version: v1.7.14-gke.1

Landing soon.

@ark3 ark3 closed this in 6c868db Apr 23, 2018

Container UX automation moved this from To Do to Done Apr 23, 2018

Roadmap automation moved this from Features to Completed Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment