Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make suffix stripping more robust (vpn-tcp) #557

Closed
ark3 opened this issue Apr 3, 2018 · 4 comments
Closed

Make suffix stripping more robust (vpn-tcp) #557

ark3 opened this issue Apr 3, 2018 · 4 comments
Labels
t:feature New feature or enhancement request

Comments

@ark3
Copy link
Contributor

ark3 commented Apr 3, 2018

Based on the discussion around #192 and the results from #548, it seems reasonable to disable and subsequently remove suffix stripping entirely. This will simplify the code. Until we are confident about this change, we should allow the old (stripping) behavior to be turned back on somehow.

@ark3
Copy link
Contributor Author

ark3 commented Apr 10, 2018

Due to the DNS regression issue, #578, I am changing the scope of this issue. First, we must address #578 by reverting the new behavior added by #548. Then, this issue can solve the problem cited in https://github.com/datawire/telepresence/pull/548#issuecomment-377542708 by returning NXDOMAIN until the proxy has a full set of suffixes. That should make suffix stripping more robust as initially intended.

We need to figure out how to simulate different networking environments for testing before we land any further changes to DNS behavior.

@ark3 ark3 changed the title Remove suffix stripping from proxy (vpn-tcp) Make suffix stripping more robust (vpn-tcp) Apr 10, 2018
@ofpiyush ofpiyush added the t:feature New feature or enhancement request label Jul 10, 2018
@stale
Copy link

stale bot commented Jun 9, 2020

This issue has been automatically marked as stale because it has not had recent activity.
Issue Reporter: Is this still a problem? If not, please close this issue.
Developers: Do you need more information? Is this a duplicate? What's the next step?

@stale stale bot added the stale Issue is stale and will be closed label Jun 9, 2020
@ark3
Copy link
Contributor Author

ark3 commented Jun 9, 2020

Still an issue. Next step: evaluate suffix stripping via nxdomain as described above.

@stale stale bot removed the stale Issue is stale and will be closed label Jun 9, 2020
@donnyyung
Copy link
Contributor

I believe this is no longer an issue in Telepresence 2. Here are the docs on how to install Telepresence (https://www.telepresence.io/docs/latest/install/), please re-open if you still see this issue in our latest version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feature New feature or enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants