New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make suffix stripping more robust (vpn-tcp) #557
Comments
Due to the DNS regression issue, #578, I am changing the scope of this issue. First, we must address #578 by reverting the new behavior added by #548. Then, this issue can solve the problem cited in https://github.com/datawire/telepresence/pull/548#issuecomment-377542708 by returning NXDOMAIN until the proxy has a full set of suffixes. That should make suffix stripping more robust as initially intended. We need to figure out how to simulate different networking environments for testing before we land any further changes to DNS behavior. |
This issue has been automatically marked as stale because it has not had recent activity. |
Still an issue. Next step: evaluate suffix stripping via nxdomain as described above. |
I believe this is no longer an issue in Telepresence 2. Here are the docs on how to install Telepresence (https://www.telepresence.io/docs/latest/install/), please re-open if you still see this issue in our latest version! |
Based on the discussion around #192 and the results from #548, it seems reasonable to disable and subsequently remove suffix stripping entirely. This will simplify the code. Until we are confident about this change, we should allow the old (stripping) behavior to be turned back on somehow.
The text was updated successfully, but these errors were encountered: