New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION: DNS broken for vpn-tcp in some network configurations #578

Closed
ark3 opened this Issue Apr 10, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@ark3
Contributor

ark3 commented Apr 10, 2018

The regression is due to fast-failing of known search domains not leading to the expected follow-up query under some network conditions. Unfortunately, our test suite does not hit these conditions in CI, hence the regression. See this gist for an example trace.

Let's revert our fix for #192. We will also need to reevaluate #557 thoroughly. This will require being able to simulate the problematic network conditions.

@ark3 ark3 added the bug label Apr 10, 2018

@ark3 ark3 self-assigned this Apr 10, 2018

@ark3 ark3 closed this in #580 Apr 10, 2018

ark3 added a commit that referenced this issue Apr 10, 2018

Merge pull request #580 from datawire/revert-fast-nxdomain
Revert "Replace suffix stripping with fast NXDOMAIN."
This reverts commit dee1fde.
Fixes #578
@ark3

This comment has been minimized.

Contributor

ark3 commented Apr 10, 2018

This will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment